Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145701: Fix__classdict__ &__conditional_annotations__ in class-scope inlined comprehensions#145702
Merged
gpshead merged 1 commit intopython:mainfromMar 9, 2026
Merged
Conversation
…in class-scope inlined comprehensions
JelleZijlstra approved these changesMar 9, 2026
gpshead approved these changesMar 9, 2026
Member
gpshead commentedMar 9, 2026
(opportunistically applying the backport labels - I'm not sure how far back this will need to go) |
63eaaf9 intopython:main 60 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@StanFromIreland for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 9, 2026
…in class-scope inlined comprehensions (pythonGH-145702)(cherry picked from commit63eaaf9)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 9, 2026
…in class-scope inlined comprehensions (pythonGH-145702)(cherry picked from commit63eaaf9)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-145710 is a backport of this pull request to the3.14 branch. |
GH-145711 is a backport of this pull request to the3.13 branch. |
MemberAuthor
StanFromIreland commentedMar 9, 2026
I can repro on 3.13/3.14. |
Member
JelleZijlstra commentedMar 9, 2026
I think I introduced the bug in 3.12, so yes this should be backported |
JelleZijlstra pushed a commit that referenced this pull requestMar 9, 2026
… in class-scope inlined comprehensions (GH-145702) (#145710)(cherry picked from commit63eaaf9)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>* Add `:oss-fuzz:` supportsBackports part of255e79f.Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
An extension offedbf77.
SystemErroron__classdict__/__conditional_annotations__in class-scope inlined comprehensions #145701