Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145651: Addhttp.client.{HTTPConnection,HTTPResponse}.__repr__#145653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
JackDanger wants to merge5 commits intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+57 −0
Open
Changes fromall commits
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
e4e2528 gh-145651: Add __repr__ to http.client.HTTPConnection and HTTPResponse
JackDangera3fb5a4 gh-145651: Add NEWS entry for http.client repr changes
JackDanger5628773 Address review feedback from picnixz
JackDanger7e113ba Use if block instead of ternary for port fallback
JackDangeraeb2b4c Check self.port is None first for readability
JackDangerFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletionsLib/http/client.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletionsLib/test/test_httplib.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2363,6 +2363,48 @@ def test_getting_header_defaultint(self): | ||
| header = self.resp.getheader('No-Such-Header',default=42) | ||
| self.assertEqual(header, 42) | ||
| class ReprTest(TestCase): | ||
| def test_http_connection_repr_default_port(self): | ||
| conn = client.HTTPConnection('example.com') | ||
| self.assertEqual(repr(conn), '<HTTPConnection example.com:80>') | ||
| def test_http_connection_repr_explicit_port(self): | ||
| conn = client.HTTPConnection('example.com', 8080) | ||
| self.assertEqual(repr(conn), '<HTTPConnection example.com:8080>') | ||
| @unittest.skipUnless(hasattr(client, 'HTTPSConnection'), | ||
| 'ssl support required') | ||
| def test_https_connection_repr(self): | ||
| conn = client.HTTPSConnection('example.com') | ||
| self.assertEqual(repr(conn), '<HTTPSConnection example.com:443>') | ||
| @unittest.skipUnless(hasattr(client, 'HTTPSConnection'), | ||
| 'ssl support required') | ||
| def test_https_connection_repr_explicit_port(self): | ||
| conn = client.HTTPSConnection('example.com', 8443) | ||
| self.assertEqual(repr(conn), '<HTTPSConnection example.com:8443>') | ||
| def test_http_response_repr_before_read(self): | ||
| sock = FakeSocket(b'HTTP/1.1 200 OK\r\n\r\n') | ||
| resp = client.HTTPResponse(sock) | ||
| self.assertEqual(repr(resp), '<HTTPResponse>') | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Would this representation really make sense? it looks a bit... invalid. Maybe | ||
| def test_http_response_repr_after_read(self): | ||
| body = b'HTTP/1.1 200 OK\r\nContent-Length: 0\r\n\r\n' | ||
| sock = FakeSocket(body) | ||
| resp = client.HTTPResponse(sock) | ||
| resp.begin() | ||
| self.assertEqual(repr(resp), '<HTTPResponse [200 OK]>') | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Is the representation actually the same as for httpx/requests? | ||
| def test_http_response_repr_not_found(self): | ||
| body = b'HTTP/1.1 404 Not Found\r\nContent-Length: 0\r\n\r\n' | ||
| sock = FakeSocket(body) | ||
| resp = client.HTTPResponse(sock) | ||
| resp.begin() | ||
| self.assertEqual(repr(resp), '<HTTPResponse [404 Not Found]>') | ||
| class TunnelTests(TestCase): | ||
| def setUp(self): | ||
| response_text = ( | ||
3 changes: 3 additions & 0 deletionsMisc/NEWS.d/next/Library/2026-03-08-00-00-00.gh-issue-145651.HtRepr.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Add :meth:`~object.__repr__` support to :class:`http.client.HTTPConnection` and | ||
| :class:`http.client.HTTPResponse`, showing host/port and status/reason | ||
| respectively. |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.