Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145376: Fix various refleaks Objects/#145609
Open
eendebakpt wants to merge 10 commits intopython:mainfrom
Open
gh-145376: Fix various refleaks Objects/#145609eendebakpt wants to merge 10 commits intopython:mainfrom
eendebakpt wants to merge 10 commits intopython:mainfrom
Conversation
Modules/_cursesmodule.c Outdated
| attr_old = getattrs(self->win); | ||
| if (curses_wattrset(self, attr, "addstr") < 0) { | ||
| curses_release_wstr(strtype, wstr); | ||
| Py_DECREF(bytesobj); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Be careful here.PyCurses_ConvertToString has a weird return type so youmight not necessarily havebytesobj set to something (it might be inwstr instead).
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good catch!
Objects/typevarobject.c Outdated
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you move this line after theif instead so we don't have to worry about cleaning up the ref?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.