Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145599: Reject control characters inhttp.cookies.Morsel.update() andhttp.cookies.BaseCookie.js_output#145600
Open
StanFromIreland wants to merge 3 commits intopython:mainfrom
Open
gh-145599: Reject control characters inhttp.cookies.Morsel.update() andhttp.cookies.BaseCookie.js_output#145600StanFromIreland wants to merge 3 commits intopython:mainfrom
http.cookies.Morsel.update() andhttp.cookies.BaseCookie.js_output#145600StanFromIreland wants to merge 3 commits intopython:mainfrom
Conversation
sethmlarson approved these changesMar 6, 2026
Contributor
sethmlarson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One small comment, otherwise LGTM. Thank you!
Misc/NEWS.d/next/Security/2026-03-06-17-03-38.gh-issue-145599.kchwZV.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
http.cookies.Morselhttp.cookies.Morsel.update() andhttp.cookies.BaseCookie.js_output This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
http.cookies.Morsel#145599