Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests#145589

Merged
vstinner merged 2 commits intopython:mainfrom
vstinner:vsock
Mar 6, 2026
Merged

gh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests#145589
vstinner merged 2 commits intopython:mainfrom
vstinner:vsock

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedMar 6, 2026
edited by bedevere-appbot
Loading

Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in the server. Skip the test if bind() fails with EADDRNOTAVAIL.

Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in theserver. Skip the test if bind() fails with EADDRNOTAVAIL.
@vstinner
Copy link
MemberAuthor

This change fix AMD64 Fedora Stable 3.x and PPC64LE Fedora Stable 3.x where test_socket fails without this change. On these two buildbot workers, the test is now skipped with:

$ ./python -m test -v test_socket -m ThreadedVSOCKSocketStreamTest -v...testStream (test.test_socket.ThreadedVSOCKSocketStreamTest.testStream) ... skipped "bind() failed with OSError(99, 'Cannot assign requested address')"

On s390x Fedora Stable 3.x, test_socket pass without this change, and still pass with this change.

$ ./python -m test test_socket -m ThreadedVSOCKSocketStreamTest -v...testStream (test.test_socket.ThreadedVSOCKSocketStreamTest.testStream) ... ok

@vstinnervstinner added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 6, 2026
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@vstinner for commit4d24cb3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145589%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMar 6, 2026
@vstinnervstinner merged commit6c8c72f intopython:mainMar 6, 2026
88 of 94 checks passed
@vstinnervstinner deleted the vsock branchMarch 6, 2026 15:51
@miss-islington-app
Copy link

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 6, 2026
…-145589)Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in theserver. Skip the test if bind() fails with EADDRNOTAVAIL.Log vsock CID in test.pythoninfo.(cherry picked from commit6c8c72f)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-145593 is a backport of this pull request to the3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 6, 2026
…-145589)Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in theserver. Skip the test if bind() fails with EADDRNOTAVAIL.Log vsock CID in test.pythoninfo.(cherry picked from commit6c8c72f)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMar 6, 2026
@bedevere-app
Copy link

GH-145594 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 6, 2026
vstinner added a commit that referenced this pull requestMar 6, 2026
…) (#145593)gh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests (GH-145589)Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in theserver. Skip the test if bind() fails with EADDRNOTAVAIL.Log vsock CID in test.pythoninfo.(cherry picked from commit6c8c72f)Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull requestMar 6, 2026
…) (#145594)gh-145548: Use VMADDR_CID_LOCAL in VSOCK socket tests (GH-145589)Prefer VMADDR_CID_LOCAL instead of VMADDR_CID_ANY for bind() in theserver. Skip the test if bind() fails with EADDRNOTAVAIL.Log vsock CID in test.pythoninfo.(cherry picked from commit6c8c72f)Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@bedevere-bot

[8]ページ先頭

©2009-2026 Movatter.jp