Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-116738: Make mmap.set_name thread-safe#145555
Merged
corona10 merged 3 commits intopython:mainfromMar 7, 2026
Merged
Conversation
Member
vstinner commentedMar 5, 2026
aisk commentedMar 6, 2026
Misc/NEWS.d/next/Core_and_Builtins/2026-03-06-01-36-20.gh-issue-116738.OWVWRx.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
vstinner approved these changesMar 6, 2026
Member
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. It sounds reasonable to add a critical section to get a consistent view of the memory mapping.
corona10 approved these changesMar 7, 2026
Member
corona10 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm!
46761c9 intopython:main 54 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
mmap.resizemay update the pointer todataandsize, which is under the protection of a critical section.In
mmap.set_name, it usesdataandsizeto annotate the mmap, but it does not have a critical section around it. So it may use an invaliddataandsizecombination, which may have problems.