Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-144741: Fix test_frame_pointer_unwind for libpython#145499
Merged
vstinner merged 1 commit intopython:mainfromMar 4, 2026
Merged
gh-144741: Fix test_frame_pointer_unwind for libpython#145499vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
Fix test_frame_pointer_unwind when Python is built with--enable-shared. Classify also libpython frames as "python".
MemberAuthor
vstinner commentedMar 4, 2026
MemberAuthor
vstinner commentedMar 4, 2026
pablogsal approved these changesMar 4, 2026
Member
pablogsal commentedMar 4, 2026
Great catch! |
Member
pablogsal commentedMar 4, 2026
diegorusso approved these changesMar 4, 2026
Contributor
diegorusso left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree, excellent stuff!
MemberAuthor
vstinner commentedMar 4, 2026
The JIT failures are unrelated and should be fixed by#145496 (which increases |
a003923 intopython:main 67 of 73 checks passed
Uh oh!
There was an error while loading.Please reload this page.
MemberAuthor
vstinner commentedMar 4, 2026
Merged. Thanks for your reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix test_frame_pointer_unwind when Python is built with --enable-shared. Classify also libpython frames as "python".
yes-off) #144741