Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.13] gh-144872: fix heap buffer overflow_PyTokenizer_ensure_utf8 (GH-144807)#145441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletionsLib/test/test_source_encoding.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -64,6 +64,23 @@ def test_issue7820(self):
# two bytes in common with the UTF-8 BOM
self.assertRaises(SyntaxError, eval, b'\xef\xbb\x20')

def test_truncated_utf8_at_eof(self):
# Regression test for https://issues.oss-fuzz.com/issues/451112368
# Truncated multi-byte UTF-8 sequences at end of input caused an
# out-of-bounds read in Parser/tokenizer/helpers.c:valid_utf8().
truncated = [
b'\xc2', # 2-byte lead, missing 1 continuation
b'\xdf', # 2-byte lead, missing 1 continuation
b'\xe0', # 3-byte lead, missing 2 continuations
b'\xe0\xa0', # 3-byte lead, missing 1 continuation
b'\xf0\x90', # 4-byte lead, missing 2 continuations
b'\xf0\x90\x80', # 4-byte lead, missing 1 continuation
b'\xf3', # 4-byte lead, missing 3 (the oss-fuzz reproducer)
]
for seq in truncated:
with self.subTest(seq=seq):
self.assertRaises(SyntaxError, compile, seq, '<test>', 'exec')

@requires_subprocess()
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI: this line caused the conflict.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

damn

StanFromIreland reacted with thumbs up emoji
def test_20731(self):
sub = subprocess.Popen([sys.executable,
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
Fix heap buffer overflow in the parser found by OSS-Fuzz.
6 changes: 4 additions & 2 deletionsParser/tokenizer/helpers.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -481,9 +481,11 @@ valid_utf8(const unsigned char* s)
return 0;
}
length = expected + 1;
for (;expected;expected--)
if (s[expected] < 0x80 || s[expected] >= 0xC0)
for (int i = 1; i <=expected;i++) {
if (s[i] < 0x80 || s[i] >= 0xC0) {
return 0;
}
}
return length;
}

Expand Down

[8]ページ先頭

©2009-2026 Movatter.jp