🤖 New build scheduled with the buildbot fleet by@vstinner for commita894262 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145439%2Fmerge

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

Tests failed on 5 buildbots, but failures are unrelated to this change.

buildbot/AMD64 CentOS9 NoGIL Refleaks PR

FAIL: test_free_reference (test.test_concurrent_futures.test_thread_pool.ThreadPoolExecutorTest.test_free_reference)

buildbot/AMD64 Fedora Stable Clang Installed PR
buildbot/PPC64LE Fedora Stable Clang Installed PR
buildbot/s390x Fedora Stable Clang Installed PR
buildbot/x86 Debian Installed with X PR

3 tests failed:test_datetime test_import test_interpreters. It should be fixed by commit46c5c57.

The PR is now ready for review.

cc@picnixz@aisk

Merged. Thanks for the review!

@picnixz:

Are there actually other places where we use the path converter and that would be useful? (that is, do you plan to look at other modules as follow-up?)

I had a look and I didn't find other places with the same bug.

• path_converter() andpath_t are specific toposixmodule.c.
• PyObject_AsFileDescriptor() fails with ValueError if the file descriptor is negative, so check for errors usingfd == -1 orfd < 0 is correct.
• _PyLong_FileDescriptor_Converter() callsPyObject_AsFileDescriptor().
• Argument Clinic generatesPyObject_AsFileDescriptor() calls when usingfildes type.
• open() callsFileIO() which also explicitly rejects negative file descriptors.