gh-145413: Fix nested attribute suggestions executing property code#145414

Open

Hiumee wants to merge 3 commits intopython:mainfrom

Hiumee:fix-issue-145413

Open

gh-145413: Fix nested attribute suggestions executing property code#145414
Hiumee wants to merge 3 commits intopython:mainfrom
Hiumee:fix-issue-145413

Conversation

Copy link

Hiumee commentedMar 2, 2026•
edited by github-actionsbot
Loading

Updated the code of_check_for_nested_attribute to check properties without triggering their code. This approach will still suggest them

Changed a test case to look for side effects and changed some contradictory comments

Updated the news section code to include imports so the code can be tested out of the box

Example

fromdataclassesimportdataclassfrommathimportpi@dataclassclassCircle:radius:float@propertydefarea(self)->float:print("Property 'area' accessed")returnpi*self.radius**2classContainer:def__init__(self,inner:Circle)->None:self.inner=innercircle=Circle(radius=4.0)container=Container(circle)print(container.area)

Output

Traceback (most recent call last):  File "<stdin>", line 1, in <module>    print(container.area)          ^^^^^^^^^^^^^^AttributeError: 'Container' object has no attribute 'area'. Did you mean '.inner.area' instead of '.area'?

It doesn't reach the print statement at all