Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145376: Fix various reference leaks#145377
Conversation
Uh oh!
There was an error while loading.Please reload this page.
zware commentedMar 1, 2026
Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :) |
JelleZijlstra commentedMar 1, 2026
I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like. |
zware commentedMar 2, 2026
I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it. |
bd13cc0 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Thanks@JelleZijlstra for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry,@JelleZijlstra and@encukou, I could not cleanly backport this to |
Sorry,@JelleZijlstra and@encukou, I could not cleanly backport this to |
Uh oh!
There was an error while loading.Please reload this page.
All found by Codex.