Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-145376: Fix various reference leaks#145377

Merged
encukou merged 1 commit intopython:mainfrom
JelleZijlstra:refcount-bugs
Mar 3, 2026
Merged

gh-145376: Fix various reference leaks#145377
encukou merged 1 commit intopython:mainfrom
JelleZijlstra:refcount-bugs

Conversation

@JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMar 1, 2026
edited by bedevere-appbot
Loading

@zware
Copy link
Member

Is there any improving the test suite to catch this kind of thing with the refleak bots? A quick glance suggests probably not, but it's worth at least getting a proper answer to the question written down :)

@JelleZijlstra
Copy link
MemberAuthor

I think a few of these could be caught with a test, yes. It doesn't feel extremely high value (these particular paths aren't likely to regress), but I can add some if you like.

encukou reacted with thumbs up emoji

@zware
Copy link
Member

I'm in no position to make that value judgement :). More test coverage is generally better, but if they're not worth it they're not worth it.

@encukouencukou merged commitbd13cc0 intopython:mainMar 3, 2026
57 checks passed
@miss-islington-app
Copy link

Thanks@JelleZijlstra for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@JelleZijlstra and@encukou, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.14

@miss-islington-app
Copy link

Sorry,@JelleZijlstra and@encukou, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker bd13cc09faaef01635aea85130f33aa8cbb8b177 3.13

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn left review comments

@sergey-miryanovsergey-miryanovsergey-miryanov approved these changes

@kumaraditya303kumaraditya303kumaraditya303 approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees

@encukouencukou

Labels

needs backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JelleZijlstra@zware@sergey-miryanov@sobolevn@kumaraditya303@encukou

[8]ページ先頭

©2009-2026 Movatter.jp