Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-145334: Make lazy import tests discoverable#145336

Merged
pablogsal merged 8 commits intopython:mainfrom
johnslavik:fix-test-layout-lazy-imports
Feb 28, 2026
Merged

gh-145334: Make lazy import tests discoverable#145336
pablogsal merged 8 commits intopython:mainfrom
johnslavik:fix-test-layout-lazy-imports

Conversation

@johnslavik
Copy link
Member

@johnslavikjohnslavik commentedFeb 27, 2026•
edited by bedevere-appbot
Loading

@johnslavikjohnslavik changed the titlegh-145334: Movetest_import.test_lazy_imports totest.test_lazy_importgh-145334: Movetest.test_import.test_lazy_imports totest.test_lazy_importFeb 27, 2026
@johnslavik
Copy link
MemberAuthor

johnslavik commentedFeb 27, 2026•
edited
Loading

Conflicts. Sorry, I'll force-push this one time, practicality beats purity.

@johnslavikjohnslavik marked this pull request as draftFebruary 27, 2026 23:34
@johnslavikjohnslavikforce-pushed thefix-test-layout-lazy-imports branch fromcb2a385 to78d584aCompareFebruary 27, 2026 23:38
@johnslavikjohnslavik marked this pull request as ready for reviewFebruary 27, 2026 23:38
@AlexWaygoodAlexWaygood removed their request for reviewFebruary 27, 2026 23:47
@brettcannonbrettcannon removed their request for reviewFebruary 27, 2026 23:47
@johnslavikjohnslavik changed the titlegh-145334: Movetest.test_import.test_lazy_imports totest.test_lazy_importgh-145334: Make lazy import tests discoverableFeb 28, 2026
@pablogsal
Copy link
Member

I have cloned this locally and run a bunch of checks to see that the new files make sense and we are not loosing anything here so I am satisfied. Thanks a lot@johnslavik! Great work 🥇

johnslavik reacted with heart emoji

@pablogsal
Copy link
Member

We should test with an installed python because of the makefile changes. Will do this now

@pablogsal
Copy link
Member

$ ./configure --prefix=$PWD/inst -C$  make install -j$ main fix-test-layout-lazy-imports ? ❯ ./inst/bin/python3 -m test test_lazy_importUsing random seed: 21143206660:00:00 load avg: 7.47 Run 1 test sequentially in a single process0:00:00 load avg: 7.47 [1/1] test_lazy_importBAR_MODULE_LOADED0:00:00 load avg: 7.47 [1/1] test_lazy_import passed== Tests result: SUCCESS ==1 test OK.Total duration: 655 msTotal tests: run=91Total test files: run=1/1Result: SUCCESS

@pablogsal
Copy link
Member

We are golden

@pablogsalpablogsal merged commita66d518 intopython:mainFeb 28, 2026
49 checks passed
bkap123 pushed a commit to bkap123/cpython that referenced this pull requestFeb 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal approved these changes

@Yhg1sYhg1sAwaiting requested review from Yhg1sYhg1s is a code owner

@DinoVDinoVAwaiting requested review from DinoVDinoV is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@webknjazwebknjazAwaiting requested review from webknjazwebknjaz is a code owner

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnslavik@pablogsal
[8]ページ先頭
©2009-2026 Movatter.jp