Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145177: Support multiple Emscripten versions for Emscripten buildbot#145180
gh-145177: Support multiple Emscripten versions for Emscripten buildbot#145180freakboy3742 merged 7 commits intopython:mainfrom
Conversation
…buildbotThis adds an `--emsdk-cache` argument to the Emscripten build script and anemscripten_version.txt file. If the `--emsdk-cache` argument is passed, the build scriptwill look in emscripten_version.txt to get the expected emsdk version is installed in afolder called e.g., 4.0.12 in the directory indicated by the `--emsdk-cache` argument.Otherwise, it will exit with an error.
hoodmane commentedFeb 26, 2026
Would appreciate review on this one next@freakboy3742 |
freakboy3742 commentedFeb 27, 2026
Ack - I've been tied up with some other things at work. Will take a look as soon as I get a moment - probably early next week. |
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The basic structure for this looks good; the only question is about whether it... actually works. The environment persistence stuff doesn't seem to work like this code suggests it will.
I know you've made the change to put the Emscripten version in code; however, Brett's comment about making it easy to backport is a fair one - maybe we want to revert to the older approach?
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
This reverts commitf1a5336.
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good, and worked in my testing; one clarifying question inline that doesn't seem to impact on how the script works, but I want to make sure I understand the reasoning for the choice.
Uh oh!
There was an error while loading.Please reload this page.
freakboy3742 commentedMar 5, 2026
!buildbot emscripten |
bedevere-bot commentedMar 5, 2026
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commit90f65ea 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742 commentedMar 5, 2026
Looks like#145439 has broken CI for Emscripten; we'll need to fix that before landing this PR. |
freakboy3742 commentedMar 5, 2026
On the subject of which - add "adding Emscripten to GitHub CI" to the TODO list, as that will help avoid this sort of problem, and CI is otherwise stable. |
hoodmane commentedMar 5, 2026
!buildbot emscripten |
bedevere-bot commentedMar 5, 2026
🤖 New build scheduled with the buildbot fleet by@hoodmane for commit3b80a0b 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742 commentedMar 5, 2026
!buildbot emscripten |
bedevere-bot commentedMar 5, 2026
🤖 New build scheduled with the buildbot fleet by@freakboy3742 for commitb66e2fa 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145180%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 Looks great - thanks for those updates.
c3fb0d9 intopython:mainUh oh!
There was an error while loading.Please reload this page.
freakboy3742 commentedMar 6, 2026
@hoodmane I guess the question is whether we backport this to 3.14. That would make updating the buildbot script easier... |
hoodmane commentedMar 6, 2026
Yes, please backport. Thanks@freakboy3742! |
Thanks@hoodmane for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…buildbot (pythonGH-145180)Adds an `--emsdk-cache` argument to the Emscripten build script and anemscripten_version.txt file. If the `--emsdk-cache` argument is passed, the build scriptwill look in `emscripten_version.txt` to get the expected emsdk version is installed ina folder called e.g., 4.0.12 in the directory indicated by the `--emsdk-cache` argument,and run the build with that Emscripten tooling activated.(cherry picked from commitc3fb0d9)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
GH-145582 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
This adds an
--emsdk-cacheargument to the Emscripten build script and an emscripten_version.txt file. If the--emsdk-cacheargument is passed, the build script will look in emscripten_version.txt to get the expected emsdk version is installed in a folder called e.g., 4.0.12 in the directory indicated by the--emsdk-cacheargument. Otherwise, it will exit with an error.