Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.1k
Comments
[3.13] gh-145008: Maintain stack consistency in CALL_BOUND_METHOD_EXACT_ARGS#145015
Open
Fidget-Spinner wants to merge 4 commits intopython:3.13from
Open
[3.13] gh-145008: Maintain stack consistency in CALL_BOUND_METHOD_EXACT_ARGS#145015Fidget-Spinner wants to merge 4 commits intopython:3.13from
Fidget-Spinner wants to merge 4 commits intopython:3.13from
Conversation
…Spinner/cpython into 3.13_recursion_inconsistency_fix
This was referencedFeb 19, 2026
marc-hb commentedFeb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The problem is that 3.13 actually doesn't guarantee stack consistency always between uops. This manifests as a bug that seems like stack corruption. In 3.14 and 3.15, this isn't a problem because we guarantee stack consistency between uops always by flushing or otherwise. The bandaid for 3.13 is to move all deopts to before we modify the stack.
@marc-hb could you please try the patch and check if it fixes your code? I tried on my end and it does, just need a second checker.
Can't test this easily, as it depends on specific recursion limits and interaction of specialization.