Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-39452: Improve the __main__ module documentation#14487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
geryogam wants to merge5 commits intopython:mainfromgeryogam:patch-9

Conversation

geryogam
Copy link
Contributor

@geryogamgeryogam commentedJun 30, 2019•
edited
Loading

This PR will apply the following changes on the__main__ module documentation:

  • replace an incorrect use of "script" with "code";
  • replace incorrect and inconsistent uses of "scope" with "environment";
  • add missing cases where the__main__ module is also initialized (when using the-c and-m arguments);
  • replace the ambiguous "when it is imported" by "not initialized from an import statement" since using a-m argument also performs import for instance;
  • add missing cases for the conditional execution of theif body (all the cases when the module is not initialized from an import statement);
  • make theif block commentPEP 8-compliant (capital initialised, period ended);
  • add a missing case for the conditional execution of the __main__.py submodule of a package (when the package is initialized from a file argument).

https://bugs.python.org/issue39452

@geryogamgeryogam marked this pull request as ready for reviewJune 30, 2019 17:24
Copy link
Contributor

@mangrisanomangrisano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@geryogamgeryogam changed the titleUpdate __main__.rstUpdate the __main__ module documentationAug 7, 2019
@geryogamgeryogam changed the titleUpdate the __main__ module documentationImprove the __main__ module documentationAug 7, 2019
@mariatta-bot
Copy link

🤖 Mariatta was mentioned, but she's out of open source until end of September 2019. Hopefully someone else can look into this in the meantime.

@csabella
Copy link
Contributor

@maggyero, please open a bug tracker ticket for this. That will provide the chance for more people to see the change and comment on it. Thanks!

@geryogamgeryogam changed the titleImprove the __main__ module documentationbpo-39452: Improve the __main__ module documentationJan 25, 2020
@geryogam
Copy link
ContributorAuthor

Done@csabella.

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To me, at least the first two changes in the description are wrong. See the issue for discussion.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@geryogam
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedy
Copy link
Member

Remove trailing whitespace with patchcheck, as mentioned in devguide.

@terryjreedy
Copy link
Member

@stevendaprano Changes were made in response to your review on the issue.

@geryogam
Copy link
ContributorAuthor

@terryjreedy

Remove trailing whitespace with patchcheck, as mentioned in devguide.

Done.

@ambv
Copy link
Contributor

Closing in favor ofGH-26883.

@ambvambv closed thisAug 24, 2021
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mangrisanomangrisanomangrisano approved these changes

@terryjreedyterryjreedyAwaiting requested review from terryjreedy

@stevendapranostevendapranoAwaiting requested review from stevendaprano

Assignees
No one assigned
Labels
awaiting change reviewdocsDocumentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@geryogam@mariatta-bot@csabella@bedevere-bot@terryjreedy@ambv@mangrisano@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp