Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805
gh-136728: Combine OpenSSL and AWS-LC CI configurations#144805hugovk merged 9 commits intopython:mainfrom
Conversation
Uh oh!
There was an error while loading.Please reload this page.
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, this approach also looks fine by me :)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Collapse matrix entries into more concise one line each.
Remove obsolete OpenSSL 1.1.1w; AWS-LC is roughly 1.1.1-shaped andexercises the relevant APIs.
Remove AWS-LC 1.55.0; just test the single latest version.
hugovk left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks both!
| ssllib: | ||
| # See Tools/ssl/make_ssl_data.py for notes on adding a new version | ||
| ## OpenSSL | ||
| - { name: openssl, version: 3.0.19 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nested objects in the matrix generally cause difficulties. So yes, that other PR solves this bit better. I understand the desire to couple libs with their versions and it might be reasonable to just use strings likeopenssl == 3.0.19 and split them where necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What difficulties?
Uh oh!
There was an error while loading.Please reload this page.
…rations"This reverts commit4676575.
Quote `${{ }}` substitutions in commands.AWS-LC 1.68.0 is already out, might as well use it.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok for thoses changes. I don't know about the changes for GHA.
c9b96b1 intopython:mainUh oh!
There was an error while loading.Please reload this page.
hugovk commentedMar 1, 2026
Can we backport this, if it's not too difficult? Will make future maintenance easier. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry,@zware and@hugovk, I could not cleanly backport this to |
zware commentedMar 1, 2026
It's apparently notthat easy to backport :). I'll give it a try. |
…ythonGH-144805)(cherry picked from commitc9b96b1)Co-authored-by: Zachary Ware <zach@python.org>
GH-145397 is a backport of this pull request to the3.14 branch. |
Uh oh!
There was an error while loading.Please reload this page.
I accidentally started this before findingGH-143940, but given the somewhat different approach I figured it was worth sharing anyway. If we prefer theGH-143940 approach, this can just be closed.