Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime#144740
Conversation
…t compile-time version, not runtime
hroncok commentedFeb 12, 2026
I'm yet to actually test this by the described reproducer. |
hroncok commentedFeb 12, 2026
It works. |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. It makes sense to check for.SetAllocTrackerMaximumAmplification attribute (method) instead of relying on the expat version.
@picnixz: Do you want to double check this change?
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thinkSetBillionLaughsAttackProtectionActivationThreshold also suffers from that so the test guarding for expat 2.4 should also be guarded. I don't remember whether 3.13 was the release that included that one or if it was something that was already there for a long time. You can address that in a follow-up PR though.
45e9343 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Sorry,@hroncok and@vstinner, I could not cleanly backport this to |
Sorry,@hroncok and@vstinner, I could not cleanly backport this to |
…t compile-time version, not runtime (python#144740)(cherry picked from commit45e9343)
GH-145494 is a backport of this pull request to the3.14 branch. |
vstinner commentedMar 4, 2026
Merged. Thanks for the fix@hroncok. |
…on expat compile-time version, not runtime (pythonGH-144740) (pythonGH-145494)pythonGH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (pythonGH-144740)(cherry picked from commit45e9343)(cherry picked from commitbcc2dd8)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Miro Hrončok <miro@hroncok.cz>
…at compile-time version, not runtime (GH-144740) (GH-145494) (#145510)[3.14]GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (GH-144740) (GH-145494)GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (GH-144740)(cherry picked from commit45e9343)(cherry picked from commitbcc2dd8)Co-authored-by: Victor Stinner <vstinner@python.org>Co-authored-by: Miro Hrončok <miro@hroncok.cz>
hroncok commentedMar 4, 2026
FTR I don't have an environment with epxat that old, so I won't be driving that change. |
Uh oh!
There was an error while loading.Please reload this page.
test_pyexpat.MemoryProtectionTestfails when Python was built with expat 2.7.1 but runs with 2.7.2 #144739