cc.@malemburg@serhiy-storchaka

Hi! Could you take a look on these changes?

Are you sure that _locale._getdefaultlocale() will no longer return a Windows locale code ?

Are you sure that _locale._getdefaultlocale() will no longer return a Windows locale code ?

As far as I know,LOCALE_SISO639LANGNAME andLOCALE_SISO3166CTRYNAME aredocumented as introduced since Windows ME/98, if that stands correctly, the hex code fallback is never getting usedsince Python 2.6, which dropped support to Windows 95/98/ME (NT 4).

Looking into git blame, the fallback code was written at 26 years ago8f017a0, but it never get removed, and surprisingly the dictionary was maintained even after Windows 95 support were entirely removed0a86694

I think we should still leave a guard in the code, so that such codes do not leak outside the function. The guard should raise an exception and let the user know that something is wrong.

Also, please have a look on Github whether the windows_locale is in use by Python 3 code. We may have to do a deprecation cycle (though it was already indirectly put through this as part of the now undone deprecation of getdefaultencoding()).

I think we should still leave a guard in the code, so that such codes do not leak outside the function. The guard should raise an exception and let the user know that something is wrong.

With the current mechanism, if any ofLOCALE_SISO3166CTRYNAME,LOCALE_SISO639LANGNAME was not avaliable, forcode a None is returned, and the legacy code in that case (if ever executed) will returnNone as code when the hex code not found in windows_locale
I will add that into documentation

Also, please have a look on Github whether the windows_locale is in use by Python 3 code. We may have to do a deprecation cycle (though it was already indirectly put through this as part of the now undone deprecation of getdefaultencoding()).

Okay, I will do so soon as have time

Right, undocumented though, there are many code relying on thewindows_locale dictionary, it cannot be simply removed..
By the way, where shall I mark a dictionary as deprecated?

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Now I believe it does no impact to python users, removed the NEWS entry

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@malemburg: please review the changes made to this pull request.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

I have made the requested changes; please review again

Thanks for making the requested changes!

@malemburg,@serhiy-storchaka: please review the changes made to this pull request.