Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions#144669

Closed
vstinner wants to merge 2 commits intopython:3.14from
vstinner:windows_2025
Closed

[3.14] gh-138744: Upgrade Windows to 2025 in GitHub Actions#144669
vstinner wants to merge 2 commits intopython:3.14from
vstinner:windows_2025

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedFeb 10, 2026•
edited by bedevere-appbot
Loading

Replace windows-2022 with windows-2025.

@vstinner
Copy link
MemberAuthor

I skipped test_dtrace on Windows in the 3.14 branch:#144657. So tests should pass again on Windows 2025.

@vstinner
Copy link
MemberAuthor

cc@Fidget-Spinner

@vstinnervstinner marked this pull request as draftFebruary 10, 2026 14:50
@vstinner
Copy link
MemberAuthor

The Windows CI was skipped since my PR only modify files of the.github/ directory. I mark my PR as a draft and modify a random file (Lib/test/test_dtrace.py) to trigger the Windows CI.

StanFromIreland and webknjaz reacted with thumbs up emoji

@vstinner
Copy link
MemberAuthor

All Windows CIs passed. Examples:

JIT / i686-pc-windows-msvc/msvc (Debug) (pull_request)JIT / i686-pc-windows-msvc/msvc (Release) (pull_request)JIT / x86_64-pc-windows-msvc/msvc (Debug) (pull_request)JIT / x86_64-pc-windows-msvc/msvc (Release) (pull_request)Tail calling interpreter / x86_64-pc-windows-msvc/msvc (pull_request)Tests / Windows (free-threading) / Build and test (arm64) (pull_request)Tests / Windows (free-threading) / Build and test (x64) (pull_request)Tests / Windows / Build and test (arm64) (pull_request)Tests / Windows / Build and test (Win32) (pull_request)Tests / Windows / Build and test (x64) (pull_request)Tests / Windows MSI / installer for arm64 (pull_request)Tests / Windows MSI / installer for x64 (pull_request)Tests / Windows MSI / installer for x86 (pull_request)
StanFromIreland reacted with thumbs up emoji

build:
name: installer for ${{ inputs.arch }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also make this change inmain?

build:
name: Build and test (${{ inputs.arch }})
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2022' }}
runs-on: ${{ inputs.arch == 'arm64' && 'windows-11-arm' || 'windows-2025' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And this inmain?

- target: i686-pc-windows-msvc/msvc
architecture: Win32
runner: windows-2022
runner: windows-2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also this inmain?

- target: x86_64-pc-windows-msvc/msvc
architecture: x64
runner: windows-2022
runner: windows-2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

And this?

@vstinner
Copy link
MemberAuthor

Oh, I misunderstood the commit25e99b3. I expected that it already upgraded Windows to 2025 for all CI jobs, but in fact it only changes "Windows tailcall CI".

I closed this PR to redo the change in the main branch first:#144682.

hugovk and chris-eibl reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ambvambvambv left review comments

@hugovkhugovkhugovk left review comments

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@webknjazwebknjazwebknjaz approved these changes

@brandtbucherbrandtbucherAwaiting requested review from brandtbucherbrandtbucher is a code owner

@savannahostrowskisavannahostrowskiAwaiting requested review from savannahostrowskisavannahostrowski is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@ambv@webknjaz@hugovk@StanFromIreland
[8]ページ先頭
©2009-2026 Movatter.jp