Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor jit.yml#144577

Merged
savannahostrowski merged 12 commits intopython:mainfrom
savannahostrowski:jit-yml-cleanup
Feb 22, 2026
Merged

Refactor jit.yml#144577
savannahostrowski merged 12 commits intopython:mainfrom
savannahostrowski:jit-yml-cleanup

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedFeb 7, 2026•
edited
Loading

Similar to#144553, this cleans upjit.yml. The biggest changes here are moving LLVM version to an env var, since we are only testing one version anyway, and consolidating all of the one-off jobs into one job with a matrix (we've been accumulating free-threading, JIT debug, JIT + tail call etc over time; I could probably be convinced this isn't worth the ~30 lines saved if the matrix feels too heterogeneous). I've also lessened timeout-minutes from 90 to 60 minutes to match other CI files.

I think this can also be backported to 3.14, though, the LLVM version will be 20 instead of 21.

chris-eibl reacted with rocket emoji
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Comment on lines +116 to +123
- name: Build
run: |
export SDKROOT="$(xcrun --show-sdk-path)"
# Set MACOSX_DEPLOYMENT_TARGET and -Werror=unguarded-availability to
# make sure we don't break downstream distributors (like uv):
export CFLAGS_JIT='-Werror=unguarded-availability'
export MACOSX_DEPLOYMENT_TARGET=10.15
./configure --enable-experimental-jit --enable-universalsdk --with-universal-archs=universal2 ${{ matrix.debug && '--with-pydebug' || '' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comparingtail-call.yml, that one exports a couple of paths and setsCC:

Image

Do we need this here? Or do we not need it there?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JIT auto finds required clang, so we dont need CC

hugovk and savannahostrowski reacted with thumbs up emoji
./configure --enable-experimental-jit --with-pydebug
sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh ${{env.LLVM_VERSION }}
export PATH="$(llvm-config-${{env.LLVM_VERSION }} --bindir):$PATH"
./configure --enable-experimental-jit${{ matrix.debug && '--with-pydebug' || '' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comparing again:

Image

We always setCC intail-call.yml but not here. Also below, inlinux-extras,CC is conditionally set. All intentional?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, that is intentional. Intail-call.yml, we always need clang because the tail-call interpreter uses musttail attributes that are clang-specific. For "regular" JIT jobs, we just use LLVM internally during the build process so not needed. For the JIT + tail-call, we need CC=clang again for the same reasons astail-call.yml

hugovk reacted with thumbs up emoji
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

savannahostrowski reacted with heart emoji
@savannahostrowskisavannahostrowskienabled auto-merge (squash)February 22, 2026 18:16
@savannahostrowskisavannahostrowski merged commit819ea3c intopython:mainFeb 22, 2026
63 checks passed
@miss-islington-app
Copy link

Thanks@savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@savannahostrowski, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 819ea3ca6836026bc611d0c8ea1cd5e95cbefc09 3.14

@bedevere-app
Copy link

GH-145126 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelFeb 22, 2026
savannahostrowski added a commit that referenced this pull requestFeb 23, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
bkap123 pushed a commit to bkap123/cpython that referenced this pull requestFeb 28, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

@AA-TurnerAA-TurnerAwaiting requested review from AA-Turner

@webknjazwebknjazAwaiting requested review from webknjaz

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski@hugovk@Fidget-Spinner
[8]ページ先頭
©2009-2026 Movatter.jp