Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-144552: Clean uptail-call.yml CI#144553

Merged
savannahostrowski merged 19 commits intopython:mainfrom
savannahostrowski:refactor-tailcall-yml
Feb 9, 2026
Merged

GH-144552: Clean uptail-call.yml CI#144553
savannahostrowski merged 19 commits intopython:mainfrom
savannahostrowski:refactor-tailcall-yml

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commentedFeb 6, 2026
edited by bedevere-appbot
Loading

Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for this!

@hugovk
Copy link
Member

Is thisclang-20 also the LLVM number? (in three places)

-CC=clang-20 ...+CC=clang-${{ matrix.llvm }} ...

@hugovk
Copy link
Member

Is thisclang-20 also the LLVM number? (in three places)

-CC=clang-20 ...+CC=clang-${{ matrix.llvm }} ...

Included insavannahostrowski#15, which also combines the Linux steps.

savannahostrowski reacted with thumbs up emoji

@hugovk
Copy link
Member

hugovk commentedFeb 6, 2026
edited
Loading

savannahostrowski#16 combines two Windows steps.

That will leave us with these Windows jobs:

#          - target: i686-pc-windows-msvc/msvc#            architecture: Win32#            runner: windows-2022          -target:x86_64-pc-windows-msvc/msvcarchitecture:x64runner:windows-2025-vs2026build_flags:""run_tests:true          -target:x86_64-pc-windows-msvc/msvc-free-threadingarchitecture:x64runner:windows-2025-vs2026build_flags:--disable-gilrun_tests:false#          - target: aarch64-pc-windows-msvc/msvc#            architecture: ARM64#            runner: windows-2022

Note Win32 and ARM64 are commented out, and have been since initial commit exactly one year ago! 🎂cb640b6

Only Windows x64 architecture is run. I suggest we delete the commented code, we can re-add it when we're ready.

And after combining two of the three Windows steps into one, we have two remaining:

      -name:Native Windows MSVC (release)if:runner.os == 'Windows' && matrix.architecture != 'ARM64'shell:pwshrun:|          $env:PlatformToolset = "v145"          ./PCbuild/build.bat --tail-call-interp ${{ matrix.build_flags }} -c Release -p ${{ matrix.architecture }}          if ("${{ matrix.run_tests }}" -eq "true") {            ./PCbuild/rt.bat -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3          }# No tests (yet):      -name:Emulated Windows Clang (release)if:runner.os == 'Windows' && matrix.architecture == 'ARM64'shell:pwshrun:|          choco install llvm --allow-downgrade --no-progress --version ${{ matrix.llvm }}.1.0          $env:PlatformToolset = "clangcl"          $env:LLVMToolsVersion = "${{ matrix.llvm }}.1.0"          $env:LLVMInstallDir = "C:\Program Files\LLVM"          ./PCbuild/build.bat --tail-call-interp -p ${{ matrix.architecture }}

I don't think that second one has ever been run? I suggest we delete that too. And when we're ready, we can re-add as needed. And that might be by combining into the first Windows step instead of a standalone one.

The&& matrix.architecture != 'ARM64' guard in this first step is also redundant and can be deleted.

savannahostrowski and chris-eibl reacted with thumbs up emoji

@savannahostrowski
Copy link
MemberAuthor

Thanks for the pulls@hugovk! I was initially trying to be somewhat conservative but I'm inclined to remove the unused job and commented out platforms as well. I think it'll be obvious enough if/when we need to add them back in.

Fidget-Spinner, hugovk, and chris-eibl reacted with thumbs up emoji

@hugovk
Copy link
Member

savannahostrowski#17 removes the duplicatetarget list, and then I have one more suggestion that builds on top of that.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

savannahostrowski reacted with heart emoji
@github-project-automationgithub-project-automationbot moved this from🧐 @webknjaz's review queue 📋 to⏰ Merge reminder needed 🔀 in📅 Procrastinating in public 😵‍💫Feb 9, 2026
@savannahostrowskisavannahostrowski merged commit30cfe6e intopython:mainFeb 9, 2026
34 checks passed
@github-project-automationgithub-project-automationbot moved this from⏰ Merge reminder needed 🔀 to🌈 Done 🦄 in📅 Procrastinating in public 😵‍💫Feb 9, 2026
@hugovk
Copy link
Member

And let's also backport.

@hugovkhugovk added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsFeb 10, 2026
@miss-islington-app
Copy link

Thanks@savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@savannahostrowski, I could not cleanly backport this to3.13 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 30cfe6ee23a8974625c9860bc401f60ed75b2dea 3.13

@miss-islington-app
Copy link

Sorry,@savannahostrowski, I could not cleanly backport this to3.14 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 30cfe6ee23a8974625c9860bc401f60ed75b2dea 3.14

@hugovk
Copy link
Member

hugovk commentedFeb 10, 2026
edited
Loading

Before mergingthis PR, here's the diff between3.14 andmain:

imageimage

Anything on the RHS that should not go back to3.14? Can we just copy the currentmain version back?

(And the file doesn't exist on 3.13, no need to backport there.)

@hugovkhugovk removed the needs backport to 3.13bugs and security fixes labelFeb 10, 2026
savannahostrowski added a commit to savannahostrowski/cpython that referenced this pull requestFeb 10, 2026
(cherry picked from commit30cfe6e)Co-authored-by: Savannah Ostrowski <savannah@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-144683 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelFeb 10, 2026
@chris-eibl
Copy link
Member

Anything on the RHS that should not go back to3.14? Can we just copy the currentmain version back?

3.14 cannot use VS2026 (PlatformToolSet v145) for a tailcalling build. The necessary changes are only in 3.15 (#139922)

So on 3.14 we can only use clang (or just omit it to save CI).

cc@Fidget-Spinner

Fidget-Spinner reacted with thumbs up emoji

hugovk added a commit that referenced this pull requestFeb 10, 2026
Co-authored-by: Savannah Ostrowski <savannah@python.org>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull requestFeb 15, 2026
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@webknjazwebknjazwebknjaz left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

@chris-eiblchris-eiblchris-eibl left review comments

@hugovkhugovkhugovk approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@savannahostrowski@hugovk@webknjaz@chris-eibl@Fidget-Spinner

[8]ページ先頭

©2009-2026 Movatter.jp