Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-123471: Make concurrent iteration over itertools.pairwise thread-safe#144489
Open
eendebakpt wants to merge 6 commits intopython:mainfrom
Open
gh-123471: Make concurrent iteration over itertools.pairwise thread-safe#144489eendebakpt wants to merge 6 commits intopython:mainfrom
eendebakpt wants to merge 6 commits intopython:mainfrom
Conversation
Contributor
rhettinger commentedFeb 5, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I'm thinking that this isn't the right strategy for itertools. Instead, we should implement the same semantics as for generators which is to raise an exception if a concurrent call occurs. If a user wants concurrency for either generators or itertools, then they with need to wrap the iterators with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We use a critical section similar to the approach in#132814. The ideas from an earlier PR#125417 are too complex (or not sufficient for thread-safety).
We also avoid an incref/decref pair.