Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-123471: Make concurrent iteration over itertools.accumulate thread-safe#144486
Open
eendebakpt wants to merge 4 commits intopython:mainfrom
Open
gh-123471: Make concurrent iteration over itertools.accumulate thread-safe#144486eendebakpt wants to merge 4 commits intopython:mainfrom
eendebakpt wants to merge 4 commits intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We use a critical section similar to the approach in#132814.
Note: the
accumulatehas mutable internal statelz->initialandlz->total. With some refactoring we can replace thelz->initpointer with a C int (where atomics can be used), but thelz->totalremains a pointer that is mutated on each iteration.A side benefit of the refactoring would be that a decref in
accumulate_deallocis avoided and visit inaccumulate_traverse. I decided not to include the refactoring in this PR (it would involve some churn), but if a core dev feels otherwise I will include it.