Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
RemovePYEXPAT_EXPORTS usage fromPCBuild/pyexpat.vcxproj#144462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
maxbachmann commentedFeb 3, 2026
Possibly this stems from libexpat having an |
PYEXPAT_EXPORTS usage fromPCBuild/pyexpat.vcxprojpicnixz commentedFeb 3, 2026
zooba commentedFeb 3, 2026
Seems trivial to me, I don't see any uses of the variable anywhere. |
9d0c743 intopython:mainUh oh!
There was an error while loading.Please reload this page.
hartwork commentedFeb 3, 2026
Throughout Expat upstream Git history, #git log -p -G EXPAT_EXPORTS| lsdiff --strip=1| sort -uexpat/bcb5/expat.bprexpat/bcb5/expat.makexpat/bcb5/expatw.bprexpat/bcb5/expatw.makexpat/bcb5/libexpat.bprexpat/bcb5/libexpat.makexpat/bcb5/libexpatw.bprexpat/bcb5/libexpatw.makexpat/lib/expat.dspexpat/lib/expatw.dsp And in CPython: #git log -p -G PYEXPAT_EXPORTS| lsdiff --strip=1| sort -uPCbuild8/pyexpat/pyexpat.vcprojPCbuild9/pyexpat.vcprojPCbuild/pyexpat.vcprojPCbuild/pyexpat.vcxprojPC/VS8.0/pyexpat.vcprojPC/VS9.0/pyexpat.vcproj I think it's safe to remove. |
Uh oh!
There was an error while loading.Please reload this page.
Looking through the history I was unable to find any revision where this actually did anything.
This should be a trivial enough change that it doesn't require a separate issue/news entry