Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-136879: Make os.spawn* arg signatures consistent with os.exec*#144458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Update os.spawnl, spawnle, spawnlp, and spawnlpe function signaturesto show arg0, arg1, ... explicitly, matching the os.execl family offunctions for consistency.Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Strictly speaking, this isnot the signature at runtime. At runtime, the signature isspawnl(mode, path, *args) so the... part is correct. So I think we should first decide on the issue how we want to document the expanded args. Do we want to explicitly documentspawnl(mode, path, arg0, arg1, ...), orspawnl(mode, path, arg0, ...) or simply specify thatargs must be non-empty with args[0] being the program name by convention? since we did not discuss yet about it, I am closing the PR otherwise it will be kept open for too long.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading.Please reload this page.
Summary
os.spawnl,spawnle,spawnlp, andspawnlpefunction signatures to showarg0, arg1, ...explicitlyos.execlfamily of functionsBefore:
spawnl(mode, path, ...)After:
spawnl(mode, path, arg0, arg1, ...)Source verification
Lib/os.pythat both exec* and spawn* use*argsparameterTest plan
make checkpassed🤖 Generated withClaude Code
📚 Documentation preview 📚:https://cpython-previews--144458.org.readthedocs.build/