A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

The class does exist at runtime - it's just accessed viaXMLParserType rather than directly:

>>>importxml.parsers.expatasexpat>>>expat.XMLParserType<class'pyexpat.xmlparser'>>>>expat.XMLParserType.__name__'xmlparser'>>> type(expat.ParserCreate())<class'pyexpat.xmlparser'>

The documentation already usesxmlparser in 30+ places (method signatures likexmlparser.Parse(), cross-references like:class:xmlparser``). Adding.. class:: xmlparser creates the anchor needed for those references to resolve.

The note in my PR already clarifies the access pattern:

"This type is available asxml.parsers.expat.XMLParserType."

Would this approach be acceptable, or do you prefer changing all 30+ references fromxmlparser toXMLParserType instead?

The class does exist at runtime - it's just accessed via XMLParserType rather than directly:

The name does not exist. We don't document objects that don't exist at runtime. You can't dopyexpat.xmlparser.

Would this approach be acceptable, or do you prefer changing all 30+ references from xmlparser to XMLParserType instead?

I want to think about it differently. Ideally, I'd like to have a realxmlparser at runtime but it's... weird. I also don't want to break Sphinx inventories or external links, but I also don't want to change all refs (that's what I did first). So for now, I prefer that we have a clear solution before opening PRs and thus will close this PR. In general, don't open PRs if there is no consensus on the issue or a clear solution.

The thing is, I am an action man, you know. And Python has 5000+! open issues, so plenty of room to work here.

Also, the debate can be in the PRs, that's fine for me. I can make edits on the PRs as the conversation evolves.

No, debate is in the issue.

The thing is, I am an action man, you know. And Python has 5000+! open issues, so plenty of room to work here.

Yes, but you need to be careful. If you just generate PRs with AI, we won't accept them because it takes time to review them. I prefer having 5k+ issues open rather than lots of low-quality PRs generated by an LLM.

Yeah, but 5000+ open issues is just not acceptable.