NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-136216: Update JSON RFC references from 7159 to 8259#144453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

kovan wants to merge1 commit intopython:main

base:main

Choose a base branch

fromkovan:gh-136216-json-rfc-update

Open

gh-136216: Update JSON RFC references from 7159 to 8259#144453

kovan wants to merge1 commit intopython:mainfromkovan:gh-136216-json-rfc-update

+5 −5

Conversation

Copy link

kovan commentedFeb 3, 2026•
edited by github-actionsbot
Loading

Summary

Updates JSON module documentation to reference RFC 8259 instead of RFC 7159
RFC 8259 obsoleted RFC 7159 in December 2017
Updates the errata footnote link accordingly

Test plan

make check passed
Documentation builds correctly

🤖 Generated withClaude Code

Issue:Update mentioned RFC injson module #136216

📚 Documentation preview 📚:https://cpython-previews--144453.org.readthedocs.build/

bedevere-appbot added awaiting review docs

Documentation in the Doc dir

skip news labels

Feb 3, 2026

bedevere-appbot mentioned this pull request

Feb 3, 2026

Update mentioned RFC injson module#136216

Open

github-project-automationbot added this toDocs PRs

Feb 3, 2026

github-project-automationbot moved this toTodo inDocs PRs

Feb 3, 2026

picnixz requested changes

Feb 3, 2026

View reviewed changes

Doc/library/json.rst Outdated

Comment on lines 707 to 709

		boolean, number, or string value. :rfc:`7159`(now :rfc:`8259`) removed that
		restriction, andthis module does not and has never implemented that restriction
		in either itsserializer or its deserializer.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do not change the flow of the text here. Reduce the diff.

Doc/library/json.rst


		.. [#rfc-errata] As noted in `the errata for RFC7159
		<https://www.rfc-editor.org/errata_search.php?rfc=7159>`_,
		.. [#rfc-errata] As noted in `the errata for RFC8259

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Be careful here. Is it still the correct errata?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didn't have an answer here. I'm surprised that both RFCs have the same errata.

bedevere-appbot removed the awaiting review label

Feb 3, 2026

Copy link

bedevere-appbot commentedFeb 3, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-appbot added the awaiting changes label

Feb 3, 2026

pythongh-136216: Update JSON RFC references from 7159 to 8259

0dbf920

RFC 8259 obsoleted RFC 7159 in December 2017. Update the json moduledocumentation to reference the current RFC.Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>