Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-143700: Document secrets.DEFAULT_ENTROPY#144447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
+8 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add documentation for the DEFAULT_ENTROPY constant in the secretsmodule. Document it as an opaque value that may change at any time,encouraging users to explicitly pass nbytes if they need a specificamount of entropy.Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
picnixz commentedFeb 3, 2026
When an issue is already assigned, it is customary to not take over the PR. I wanted to do it myself and I will do so when I find time. So sorry but I'm going to close this PR because I want to use an alternative wording and you have enough open PRs which will need review (so please do not open more, TiA). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
secrets.DEFAULT_ENTROPYconstantnbytesif they need a specific amount of entropyCloses#143700
Test plan
Lib/secrets.py:31)make checkin Doc/ directory passed🤖 Generated withClaude Code
📚 Documentation preview 📚:https://cpython-previews--144447.org.readthedocs.build/