Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-141444: Replace dead URL in urllib.robotparser example#144443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kovan wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromkovan:gh-141444-robotparser-url

Conversation

@kovan
Copy link

@kovankovan commentedFeb 3, 2026•
edited by github-actionsbot
Loading

Summary

  • Replace defunct musi-cal.com URL with python.org in theRobotFileParser documentation example
  • Simplify the example to show basiccan_fetch() usage since the original output values were specific to musi-cal.com's robots.txt

Closes#141444

Test plan

  • Verified python.org/robots.txt is accessible and returns valid robots.txt
  • make check in Doc/ directory passed

🤖 Generated withClaude Code

📚 Documentation preview 📚:https://cpython-previews--144443.org.readthedocs.build/

@picnixz
Copy link
Member

We do not accept changes generated solely by AI. Please readhttps://devguide.python.org/getting-started/generative-ai/.

@kovan
Copy link
Author

But the contribution is useful and/or productive; I don't think you are reading the document right. Please re-read.

@picnixz
Copy link
Member

I do think we need to update this but we don't accept AI-generated PRs.

@picnixz
Copy link
Member

In addition, the example is now smaller which isn't really good. I would also prefer that the comments in the#141461 are taken into account.

@kovan
Copy link
Author

The document is quite clear: as long as the contributions are useful or productive, it is allowed, or, rather, left to the mantainers to decide.
Maybe it could be rephrased better to avoid this kind of confussions, but I will repeat: I think you are not reading it correctly.

@picnixz
Copy link
Member

And as a maintainer, I've decided that (1) removing most of the example is not useful (2) not addressing previous PR's comment is not useful either. So, you need to address them. Simply generating this PR without acknowledging what has already been discussed in#141461 is not acceptable.

zware reacted with thumbs up emoji

@kovan
Copy link
Author

kovan commentedFeb 3, 2026•
edited
Loading

OK, now we are in talking terms. Please reopen the PR, so I can work on it; and the same for the other PR you closed.

@picnixz
Copy link
Member

The other PR is not useful. I decided not to update the documentation.

kovan reacted with thumbs up emoji

@picnixzpicnixz reopened thisFeb 3, 2026
@StanFromIreland
Copy link
Member

Aspreviously discussed, it would be better to find a non-empty example.

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Use a non-trivial example.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@StanFromIreland
Copy link
Member

We could do something likepython/pythontestdotnet#7?

Replace the defunct musi-cal.com URL with pythontest.net in theRobotFileParser documentation example. This uses CPython-controlledinfrastructure and provides non-None values for request_rate andcrawl_delay, addressing feedback from previous PRpython#141461.Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@kovankovanforce-pushed thegh-141444-robotparser-url branch fromcc57fff toda1cb06CompareFebruary 3, 2026 21:40
@kovan
Copy link
Author

I have made the requested changes; please review again

@bedevere-app
Copy link

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@kovankovan reopened thisFeb 3, 2026
Copy link
Member

@picnixzpicnixz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Those changes look better.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees

No one assigned

Labels

awaiting mergedocsDocumentation in the Doc dirskip news

Projects

Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dead example URL in urlib.robotparser documentation

3 participants

@kovan@picnixz@StanFromIreland
[8]ページ先頭
©2009-2026 Movatter.jp