Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-144316: Fix missing exception in _remote_debugging with debug=False#144442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
taegyunkim wants to merge4 commits intopython:mainChoose a base branch fromtaegyunkim:gh-144316-get_stack_trace
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+12 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7d1bb63 to0f2d244Comparecffe58f to66b060dCompareUh oh!
There was an error while loading.Please reload this page.
Misc/NEWS.d/next/Library/2026-02-03-19-57-41.gh-issue-144316.wop870.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The
set_exception_macroin_remote_debugging.honly set exceptions whenunwinder->debugwasTrue:This violates C Python API contract: functions returning NULL or -1 to indicate errors must always set an exception. When
debug=False(default), the macro did nothing, causing the function to return an error without setting an exception.Modifies
set_exception_causeto always set an exception while preserving the intended behavior ofdebugflag.RemoteUnwinder.get_stack_traceis missing exceptions on some error code paths #144316