Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-144316: Fix missing exception in _remote_debugging with debug=False#144442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
taegyunkim wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromtaegyunkim:gh-144316-get_stack_trace

Conversation

@taegyunkim
Copy link
Contributor

@taegyunkimtaegyunkim commentedFeb 3, 2026
edited by bedevere-appbot
Loading

Theset_exception_macro in_remote_debugging.h only set exceptions whenunwinder->debug wasTrue:

  #define set_exception_cause(unwinder, exc_type, message) \      if (unwinder->debug) { \          _set_debug_exception_cause(exc_type, message); \      }

This violates C Python API contract: functions returning NULL or -1 to indicate errors must always set an exception. Whendebug=False (default), the macro did nothing, causing the function to return an error without setting an exception.

Modifiesset_exception_cause to always set an exception while preserving the intended behavior ofdebug flag.

@taegyunkimtaegyunkimforce-pushed thegh-144316-get_stack_trace branch from7d1bb63 to0f2d244CompareFebruary 3, 2026 19:50
@taegyunkimtaegyunkimforce-pushed thegh-144316-get_stack_trace branch fromcffe58f to66b060dCompareFebruary 3, 2026 20:01
@taegyunkimtaegyunkim marked this pull request as ready for reviewFebruary 3, 2026 20:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz left review comments

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taegyunkim@picnixz

[8]ページ先頭

©2009-2026 Movatter.jp