Movatterモバイル変換

Skip to content

python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-139103: Use METH_FASTCALL for tp_new_wrapper#144406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

colesbury wants to merge1 commit intopython:main

base:main

Choose a base branch

fromcolesbury:gh-139103-tp-new-wrapper-fastcall

Open

gh-139103: Use METH_FASTCALL for tp_new_wrapper#144406

colesbury wants to merge1 commit intopython:mainfromcolesbury:gh-139103-tp-new-wrapper-fastcall

+18 −8

Conversation

@colesbury

Copy link

Contributor

colesbury commentedFeb 2, 2026•
edited
Loading

This addresses one of the bottlenecks when constructing namedtuple instances. With the previous METH_VARARGS, the type argument to__new__ would be included in the arguments tuple, leading to reference count contention.

@colesbury

pythongh-139103: Use METH_FASTCALL for tp_new_wrapper

7647f67

This addresses one of the bottlenecks when constructing namedtupleinstances. With the previous METH_VARARGS, the type argument to__new__ would be included in the arguments tuple, leading toreference count contention.

@bedevere-app

bedevere-appbot mentioned this pull request

Poor thread scaling when constructing instances or accessing attributes#139103

Open

@colesbury

colesbury added skip news topic-free-threading labels

@colesbury

Copy link

ContributorAuthor

colesbury commentedFeb 2, 2026

A few comments:

Pulled out from the larger PRgh-139103: Improve namedtuple scaling in free-threaded build #144332, which includes all the fixes needed to address the scaling bottleneck.
Mostly written by Claude code
Single threaded performance for the relevant Python__new__ calls is essentially with the noise margin (maybe a tiny bit faster), as measured byhttps://gist.github.com/colesbury/7c0259e0779aff2cc563c7db298edf42

vstinner

vstinner approved these changes

View reviewed changes

Copy link

Member

vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I'm not sure what's wrong with the CI.

@bedevere-app

bedevere-appbot added the awaiting merge label

@colesbury

Copy link

ContributorAuthor

colesbury commentedFeb 2, 2026

I think there are site-wide failures with GitHub Actions hosted-runners:https://www.githubstatus.com/

@colesbury

colesbury marked this pull request as ready for review

February 2, 2026 21:26

@colesbury

colesbury requested a review frommarkshannon as acode owner

February 2, 2026 21:26

@bedevere-app

bedevere-appbot added awaiting core review and removed awaiting merge labels

kumaraditya303

kumaraditya303 approved these changes

View reviewed changes

@bedevere-app

bedevere-appbot added awaiting merge and removed awaiting core review labels

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

awaiting merge skip news topic-free-threading

3 participants

@colesbury

@vstinner

@kumaraditya303

[8]ページ先頭

©2009-2026 Movatter.jp