gh-116738: Align bz2 unused_data getter to lzma implementation#144351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

yoney wants to merge1 commit intopython:main

base:main

Choose a base branch

fromyoney:ft_bz2

Open

gh-116738: Align bz2 unused_data getter to lzma implementation#144351

yoney wants to merge1 commit intopython:mainfromyoney:ft_bz2

+10 −7

Conversation

Copy link

Contributor

yoney commentedJan 30, 2026•
edited by bedevere-appbot
Loading

This is a follow-up to#142947 to alignbz2 withlzma implementations by returningb"" fromunused_data getter wheneof is not set (doc). It also refactors theunused_data to make it easier to read and to clearly show thatself->unused_data cannot beNULL (sincePyBytes_FromStringAndSize() only fails on allocation errors).

Ran the test with tsan build.

cc:@emmatyping @colesbury