Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-139103: Improve namedtuple scaling in free-threaded build#144332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
colesbury wants to merge1 commit intopython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+247 −82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add `_Py_type_getattro_stackref`, a variant of type attribute lookupthat returns `_PyStackRef` instead of `PyObject*`. This allows returningdeferred references in the free-threaded build, reducing reference countcontention when accessing type attributes.This significantly improves scaling of namedtuple instantiation acrossmultiple threads.
| // Like PyObject_GetAttr but returns a _PyStackRef. For types, this can | ||
| // return a deferred reference to reduce reference count contention. | ||
| PyAPI_FUNC(_PyStackRef)PyObject_GetAttrStackRef(PyObject*obj,PyObject*name); |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please rename it to_PyObject_GetAttrStackRef() since it's private?
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Add
_Py_type_getattro_stackref, a variant of type attribute lookup that returns_PyStackRefinstead ofPyObject*. This allows returning deferred references in the free-threaded build, reducing reference count contention when accessing type attributes.This improves scaling of namedtuple instantiation across multiple threads.