Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-144325: Improve error messages for{}-style formatters for int, float, str, and complex#144326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
python-cla-botbot commentedJan 29, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
| def test_invalid_specifier_type_error_message(self): | ||
| for value in [12j, 12, 12.0, "12"]: | ||
| for bad_spec, repr in [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit:repr is a built-in.
| forbad_spec,reprin [ | |
| forbad_spec,repr_strin [ |
| ]: | ||
| with self.subTest(value=value, bad_spec=bad_spec): | ||
| err = re.escape("Unknown format code " | ||
| f"{repr} for object of type " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| f"{repr} for object of type " | |
| f"{repr_str} for object of type " |
Uh oh!
There was an error while loading.Please reload this page.
This is the first implementation of my suggested changes in the issue.
Some proposals are open for discussion, though the PR already includes test cases.
I would appreciate any feedback or suggestions on these proposed changes.
{}style formatters for int, float, str, and complex #144325