Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-139801: fix BaseProxy pickling with custom authkey#144311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
deadlovelll wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromdeadlovelll:baseproxy-pickle

Conversation

@deadlovelll
Copy link

@deadlovellldeadlovelll commentedJan 28, 2026•
edited
Loading

Always saveauthkey inBaseProxy.__reduce__() so proxy created with a custom authkey could be picklable.

Fixesgh-139801.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@deadlovelll
Copy link
Author

deadlovelll commentedJan 28, 2026•
edited
Loading

I'll be glad to see the feedback! Thanks =)

@picnixz
Copy link
Member

picnixz commentedJan 28, 2026•
edited
Loading

Well.. one feedback I can give without looking at the PR is that tests should not fail, or you should have an idea why it fails, before requesting a review. We can't make the work of fixing the tests ourselves (otherwise we would have worked on the PR directly). So I suggest that you investigate why the tests fail and at least make sure thatsome tests succeed (at least on Ubuntu).

In the meantime, I'm marking this PR as not ready.

EDIT: I think you need to tackle a less complex issue. This issue is actually related to security and we prefer core developers making changes to security-related issues (the TypeError in the tests hint that we should not pickle some data).

@picnixzpicnixz marked this pull request as draftJanuary 28, 2026 19:54
@deadlovelll
Copy link
Author

Well.. one feedback I can give without looking at the PR is that tests should not fail, or you should have an idea why it fails, before requesting a review. We can't make the work of fixing the tests ourselves (otherwise we would have worked on the PR directly). So I suggest that you investigate why the tests fail and at least make sure thatsome tests succeed (at least on Ubuntu).

In the meantime, I'm marking this PR as not ready.

EDIT: I think you need to tackle a less complex issue. This issue is actually related to security and we prefer core developers making changes to security-related issues (the TypeError in the tests hint that we should not pickle some data).

Thank you! I'll try not to make same mistakes again

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadAwaiting requested review from gpsheadgpshead is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

multiprocessing.managers.BaseProxy can not be unpickled when using a customauthkey

2 participants

@deadlovelll@picnixz
[8]ページ先頭
©2009-2026 Movatter.jp