NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

[3.13] gh-144194: Fix mmap failure check in perf_jit_trampoline.c (#143713)#144304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:3.13fromvstinner:mmap13

Jan 28, 2026

Merged

[3.13] gh-144194: Fix mmap failure check in perf_jit_trampoline.c (#143713)#144304

vstinner merged 1 commit intopython:3.13fromvstinner:mmap13

Jan 28, 2026

+3 −1

Conversation

Copy link

Member

vstinner commentedJan 28, 2026•
edited by bedevere-appbot
Loading

mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The current check never detects mmap failures, so jitdump initialization proceeds even when the memory mapping fails.

(cherry picked from commit8fe8a94)

Issue:perf_jit_trampoline: mmap failure check uses wrong error value #144194

pythongh-144194: Fix mmap failure check in perf_jit_trampoline.c (pyt…

d7ed964

…hon#143713)mmap() returns MAP_FAILED ((void*)-1) on error, not NULL. The currentcheck never detects mmap failures, so jitdump initialization proceedseven when the memory mapping fails.(cherry picked from commit8fe8a94)