Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-144261: SyntaxWarning when await an unawaitable constant#144271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
gh-144261: SyntaxWarning when await an unawaitable constant#144271
Conversation
Locked-chess-official commentedJan 27, 2026
I will check which cause the SyntaxWarning to SyntaxError. This is on my computer:  |
| check_awaitable(compiler* c, expr_ty e) | ||
| { | ||
| /* Emit a warning when awaiting obvious non-awaitable literal objects. */ | ||
| switch (e->kind) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's better to swap the kinds and only consider kinds that are awaitable. Otherwise, we need to update that list whenever we add a new kind that is not awaitable.
picnixz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This requires a What's New entry, and tests as well.
| @@ -0,0 +1 @@ | |||
| SyntaxWarning when await an unawaitable constant. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This requires better phrasing. This does not explain anything.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
picnixz commentedJan 27, 2026
Since the PR is not ready I'm going to put it as a draft for now. |
Locked-chess-official commentedJan 28, 2026
I take a day but fail to find what upgrade "SyntaxWarning" to "SyntaxError". |
Locked-chess-official commentedJan 28, 2026
Maybe asyncdefa():x=1awaitx to avoid SyntaxWarning |
Uh oh!
There was an error while loading.Please reload this page.