Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-144257: document return values of PyModule_SetDocString#144258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ngoldbaum wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromngoldbaum:fix-setdocstring-docs

Conversation

@ngoldbaum
Copy link
Contributor

@ngoldbaumngoldbaum commentedJan 26, 2026•
edited by github-actionsbot
Loading

Copy link
Member

@sobolevnsobolevn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I propose to simplify the wording. And I propose to not go into the details about why an error can happen :)

Co-authored-by: sobolevn <mail@sobolevn.me>
@ngoldbaumngoldbaum changed the titlegh-144257: document return values and failure conditions of PyModule_SetDocStringgh-144257: document return values of PyModule_SetDocStringJan 26, 2026
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

I will keep this open for a bit, so others can also take a look :)
And merge it in several days.

ngoldbaum reacted with thumbs up emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting mergedocsDocumentation in the Doc dirskip news

Projects

Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ngoldbaum@sobolevn
[8]ページ先頭
©2009-2026 Movatter.jp