Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-144240: Fix typo in configure file: correct "defauly" to "default"#144241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@whyvineet
Copy link

@whyvineetwhyvineet commentedJan 26, 2026•
edited by bedevere-appbot
Loading

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@sergey-miryanov
Copy link
Contributor

It is not user facing, so I'm not sure it is worth to do.

johnslavik and whyvineet reacted with thumbs up emoji

@sergey-miryanov
Copy link
Contributor

@picnixz
Copy link
Member

This is code churn, it's not user-facing and it requires to regenerate the configure script and configure.ac. So I don't think it's worth it. Sorry, but I'm closing it. Please read the devguide to know what are acceptable issues. If it's not in the devguide, the general rule for typos is:

Typos are only corrected if they are user-facing (e.g., rST docs, or docstrings of library code: we don't care about typos in tests unless they are really important (e.g., the comment is wrong)).

whyvineet reacted with thumbs up emoji

@whyvineet
Copy link
Author

Sure@picnixz, I didn’t find a specific mention of this in the devguide, but I agree this typo isn’t user-facing. I’ll keep this in mind for future contributions.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@emmatypingemmatypingAwaiting requested review from emmatypingemmatyping is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typo in configure comment

3 participants

@whyvineet@sergey-miryanov@picnixz
[8]ページ先頭
©2009-2026 Movatter.jp