Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Correctly format list of references inurllib.parse docstring#144198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
bodhisilberling wants to merge2 commits intopython:main
base:main
Choose a base branch
Loading
frombodhisilberling:fix-docstring-formatting

Conversation

@bodhisilberling
Copy link
Contributor

…colon

@picnixz
Copy link
Member

Can you check if there are other typos in the docstrings of this module as well as checking the online RST docs to see if therendered content has such typos?

@picnixzpicnixz changed the titleFix docstring formatting: remove double space and extra space before …Fix typo inurllib.parse.urlsplit docstringJan 24, 2026
@picnixzpicnixz changed the titleFix typo inurllib.parse.urlsplit docstringFix typo inurllib.parse docstringJan 24, 2026
@picnixzpicnixz changed the titleFix typo inurllib.parse docstringFix typos inurllib.parse docstringJan 24, 2026
@picnixz
Copy link
Member

Actually, by looking at the file, I see that it's not the only place that the references are wrongly... produced. So... sorry but I think the change would still too big (we sometimes have "L. Masinter", sometimes "L.Masinter" and sometimes "L Masinter"). So... I would either:

  • Properly format the references in a canonical format (MLA, APA, ePrint, whichsoever is the best here).
  • Do nothing.

I'm now more inclined to actually do nothing even if the docstring is user-facing.

cc@hugovk

@hugovk
Copy link
Member

I don't mind, but the relevant RFCs all say L. Masinter at the top.

@picnixz
Copy link
Member

Ok, since it's about a list of references, let's properly list them. If it were some other stuff in the prose, maybe it would have been fine, but let's properly format the list of references (not just L. Masinter).

@picnixzpicnixz changed the titleFix typos inurllib.parse docstringCorrectly format list of references inurllib.parse docstringJan 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bodhisilberling@picnixz@hugovk

[8]ページ先頭

©2009-2026 Movatter.jp