Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
Correctly format list of references inurllib.parse docstring#144198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
picnixz commentedJan 24, 2026
Can you check if there are other typos in the docstrings of this module as well as checking the online RST docs to see if therendered content has such typos? |
urllib.parse.urlsplit docstringurllib.parse.urlsplit docstringurllib.parse docstringurllib.parse docstringurllib.parse docstringpicnixz commentedJan 26, 2026
Actually, by looking at the file, I see that it's not the only place that the references are wrongly... produced. So... sorry but I think the change would still too big (we sometimes have "L. Masinter", sometimes "L.Masinter" and sometimes "L Masinter"). So... I would either:
I'm now more inclined to actually do nothing even if the docstring is user-facing. cc@hugovk |
hugovk commentedJan 26, 2026
I don't mind, but the relevant RFCs all say L. Masinter at the top. |
picnixz commentedJan 26, 2026
Ok, since it's about a list of references, let's properly list them. If it were some other stuff in the prose, maybe it would have been fine, but let's properly format the list of references (not just L. Masinter). |
urllib.parse docstringurllib.parse docstring
…colon