Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-74902: Avoid hitting unicode.org for test data#144195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Use our own pythontest.net instead.
zware commentedJan 23, 2026
unicode.org returned 403s to a couple of my buildbot workers; using pythontest.net instead ensures that we're not taxing their server and puts the source of our test data in our control. Test data added to pythontest.net inpython/pythontestdotnet@a66b3bb |
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. 👍
| f"into the test data directory") | ||
| except (OSError, HTTPException) as exc: | ||
| self.skipTest(f"Failed to download {TESTDATAURL}: {exc}") | ||
| TESTDATAFILE = "GraphemeBreakTest.txt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So, it is not inauxiliary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is not; since we only havethree files in there (up from two before adding this one), the extra directory seemed unnecessary. Easy enough to add back if you want it, though.
58ccf21 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Use our own pythontest.net instead.