Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
tests: asyncio: collect garbage in run_until_complete_nesting#144168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The test checks that coro1 emits a runtime warning when it is garbagecollected. cpython will do this collection immediately, but otherimplementations such as PyPy might not. Add the appropriate call tosupport.gc_collect() to ensure the warning is emitted while still in thewith statement.
python-cla-botbot commentedJan 23, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz commentedJan 24, 2026
Is the only place? I would appreciate an issue for this as well. |
benzea commentedJan 24, 2026
It is the only place I noticed. But we only ran test_events.py against it for the pygobject GLibEventLoop integration tests. And even there we now switch to simply use the pypy sources instead, we pulled in the cpython version more by accident. That said, I do think it is technically a bug, and there might be more … maybe it would actually be effective to diff the pypy version and see what they changed. I suppose I can open a ticket and update the patch. I guess I'll wait a bit in case I find the motivation to check if more things need to be changed. |
picnixz commentedJan 24, 2026
Still, please open a ticket with the specific bug. If there is more to do we will update the ticket. But this is something that needs to be tracked, at least for posterity. |
The test checks that coro1 emits a runtime warning when it is garbage collected. cpython will do this collection immediately, but other implementations such as PyPy might not. Add the appropriate call to support.gc_collect() to ensure the warning is emitted while still in the with statement.