Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-143928: Remove outdated comparison between pickle and marshal regarding recursion#144025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromYashp002:outdatedmarshal
Jan 26, 2026

Conversation

@Yashp002
Copy link
Contributor

@Yashp002Yashp002 commentedJan 19, 2026•
edited by bedevere-appbot
Loading

Removes an outdated section in thepickle module documentation that incorrectly statesmarshal does not support object sharing or recursive objects.

As confirmed by core developers,marshal (protocol version 3+) supports both shared references and recursion, making the previous claim inaccurate. This change simply removes the incorrect statement without adding further comparisons, as requested.
Fixes#143298

📚 Documentation preview 📚:https://cpython-previews--144025.org.readthedocs.build/

@bedevere-appbedevere-appbot added docsDocumentation in the Doc dir skip news awaiting review labelsJan 19, 2026
@Yashp002Yashp002 changed the titlegh-[143298]: Remove outdated documentation comparing pickle and marshalgh-[#143298]: Remove outdated documentation comparing pickle and marshalJan 19, 2026
@Yashp002Yashp002 changed the titlegh-[#143298]: Remove outdated documentation comparing pickle and marshalgh-#143298: Remove outdated documentation comparing pickle and marshalJan 19, 2026
@Yashp002Yashp002 changed the titlegh-#143298: Remove outdated documentation comparing pickle and marshalgh-143298: Remove outdated documentation comparing pickle and marshalJan 19, 2026
@Yashp002Yashp002 changed the titlegh-143298: Remove outdated documentation comparing pickle and marshalgh-143928: Remove outdated comparison between pickle and marshal regarding recursionJan 19, 2026
@Yashp002
Copy link
ContributorAuthor

@picnixz Would this PR be satisfactory?

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, but please check that there is no such comparison in marshal.rst as well (maybe we have this kind of mention in marshal.rst, idk)

@Yashp002
Copy link
ContributorAuthor

@picnixz The only 4 mentions of the pickle module in marshal.rst seem to be about RPC calls and where pickle can be used. Nothing that suggests marshal doesn't support recursion or object sharing. So i think this is fine

@vstinnervstinner merged commit923d9d2 intopython:mainJan 26, 2026
40 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsJan 26, 2026
@vstinnervstinner added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 26, 2026
@miss-islington-app
Copy link

Thanks@Yashp002 for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Yashp002 reacted with thumbs up emoji

@miss-islington-app
Copy link

Thanks@Yashp002 for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 26, 2026
…l regarding recursion (pythonGH-144025)(cherry picked from commit923d9d2)Co-authored-by: Yashraj <yashrajpala8@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJan 26, 2026
…l regarding recursion (pythonGH-144025)(cherry picked from commit923d9d2)Co-authored-by: Yashraj <yashrajpala8@gmail.com>
@bedevere-app
Copy link

GH-144246 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelJan 26, 2026
@bedevere-app
Copy link

GH-144247 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelJan 26, 2026
@vstinner
Copy link
Member

Merged, thank you.

vstinner pushed a commit that referenced this pull requestJan 26, 2026
…al regarding recursion (GH-144025) (#144247)gh-143928: Remove outdated comparison between pickle and marshal regarding recursion (GH-144025)(cherry picked from commit923d9d2)Co-authored-by: Yashraj <yashrajpala8@gmail.com>
vstinner pushed a commit that referenced this pull requestJan 26, 2026
…al regarding recursion (GH-144025) (#144246)gh-143928: Remove outdated comparison between pickle and marshal regarding recursion (GH-144025)(cherry picked from commit923d9d2)Co-authored-by: Yashraj <yashrajpala8@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@picnixzpicnixzpicnixz approved these changes

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yashp002@vstinner@picnixz
[8]ページ先頭
©2009-2026 Movatter.jp