NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-143946: Show`JitOptSymbol` on abstract stack when set PYTHON_OPT_DEBUG > 4#143957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Fidget-Spinner merged 7 commits intopython:mainfromcocolato:add_debug_info

Jan 17, 2026

Merged

gh-143946: Show`JitOptSymbol` on abstract stack when set PYTHON_OPT_DEBUG > 4#143957

Fidget-Spinner merged 7 commits intopython:mainfromcocolato:add_debug_info

Jan 17, 2026

Conversation

Copy link

Contributor

cocolato commentedJan 17, 2026•
edited
Loading

Now we can get more debug info when set PYTHON_OPT_DEBUG > 4:

test_code:

deffoo():total=0foriinrange(4002):total=total+ireturntotalfoo()

RunPYTHON_OPT_DEBUG=5 ./python test.py

will get output:
debug.log

Issue:PYTHON_OPT_DEBUG=4 (or higher) should show types on the abstract stack #143946

cocolato added2 commits

January 17, 2026 19:40

show stack infos when set PYTHON_OPT_DEBUG>4

6656ba0

show stack infos when set PYTHON_OPT_DEBUG>4

a9add64

cocolato requested review fromFidget-Spinner,markshannon,savannahostrowski andtomasr8 ascode owners

January 17, 2026 11:55

bedevere-appbot added the awaiting review label

Jan 17, 2026

bedevere-appbot mentioned this pull request

Jan 17, 2026

PYTHON_OPT_DEBUG=4 (or higher) should show types on the abstract stack#143946

Closed

cocolato commented

Jan 17, 2026

View reviewed changes

Python/optimizer_symbols.cShow resolvedHide resolved

Fidget-Spinner changed the title~~gh-143946: Show_JitSymType on abstract stack when set PYTHON_OPT_DEBUG > 4~~gh-143946: ShowJitOptSymbol on abstract stack when set PYTHON_OPT_DEBUG > 4

Jan 17, 2026

simple the debug ouput

b52ce1e

Copy link

Member

Fidget-Spinner commentedJan 17, 2026

I think we also need to add aninvalid tag to the JIT ref tags. Otherwise, this might crash when we push an abstract frame onto the stack. The abstract frame should be marked as invalid.

add INVALID_TAG for abstract frame

210275a

Copy link

ContributorAuthor

cocolato commentedJan 17, 2026

updated!

fix lint

c565bbb

Copy link

Member

Fidget-Spinner commentedJan 17, 2026•
edited
Loading

Sorry that's the wrong tag, it should the tag inpycore_optimizer.h. E.g.#define REF_IS_BORROWED 1 is one of them. I think the invalid tag should followpycore_stackref.h's number

Merge branch 'main' into add_debug_info

09fe5ae

Fidget-Spinner added the skip news label

Jan 17, 2026

add INVALID tag for abstract frame

8508af7

Copy link

ContributorAuthor

cocolato commentedJan 17, 2026

I think we also need to add aninvalid tag to the JIT ref tags. Otherwise, this might crash when we push an abstract frame onto the stack. The abstract frame should be marked as invalid.

Sorry about that, I've just figured out the bitwise operations here.