NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-143952: Fix asyncio tools to work with the new remote debugging API#143954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

pablogsal merged 4 commits intopython:mainfromjohnslavik:fix-asyncio-tools-new-frameinfo-api

Jan 18, 2026

Merged

gh-143952: Fix asyncio tools to work with the new remote debugging API#143954

pablogsal merged 4 commits intopython:mainfromjohnslavik:fix-asyncio-tools-new-frameinfo-api

Jan 18, 2026

Conversation

Copy link

Member

johnslavik commentedJan 17, 2026•
edited by bedevere-appbot
Loading

Issue:Asyncio debugging tools no longer work (ps andpstree) #143952

johnslavik added2 commits

January 17, 2026 07:51

Update asyncio tools to new_remote_debugging.FrameInfo API

d40463f

Add news entry

1b52ce8

johnslavik requested review from1st1,asvetlov,kumaraditya303 andwillingc ascode owners

January 17, 2026 06:52

bedevere-appbot added the awaiting review label

Jan 17, 2026

bedevere-appbot mentioned this pull request

Jan 17, 2026

Asyncio debugging tools no longer work (ps andpstree)#143952

Closed

johnslavik requested a review frompablogsal

January 17, 2026 06:52

Copy link

Contributor

aisk commentedJan 17, 2026

Hi, I'm wondering if we can add some tests to ensure we don't break this again in the future?

johnslavik marked this pull request as draft

January 17, 2026 07:00

bedevere-appbot removed the awaiting review label

Jan 17, 2026

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026

Something's very wrong here. On it.

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026•
edited
Loading

Oh, okay. We have tests for tools but we don't import structures from_remote_debugging. Instead we have our own:

cpython/Lib/test/test_asyncio/test_tools.py

Lines 7 to 11 in1b52ce8

	FrameInfo=namedtuple('FrameInfo', ['funcname','filename','lineno'])
	CoroInfo=namedtuple('CoroInfo', ['call_stack','task_name'])
	TaskInfo=namedtuple('TaskInfo', ['task_id','task_name','coroutine_stack','awaited_by'])
	AwaitedInfo=namedtuple('AwaitedInfo', ['thread_id','awaited_by'])

CC@kumaraditya303

Fix tests

48b40a3

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026

OK I guess that's it for the fix itself!

johnslavik marked this pull request as ready for review

January 17, 2026 07:16

bedevere-appbot added the awaiting review label

Jan 17, 2026

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026•
edited
Loading

We'd want to keep these structures in sync later (we also don't have.opcode inFrameInfo in tests for instance).
I'll check the remote debugging tests in regard to how they manage these structures.

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026

OK, it's not a problem. We would just have to pass sequences and we could use original structures.

>>>from _remote_debuggingimport FrameInfo>>> FrameInfo(range(4))_remote_debugging.FrameInfo(filename=0, location=1, funcname=2, opcode=3)

Copy link

MemberAuthor

johnslavik commentedJan 17, 2026

We'd want to keep these structures in sync later (we also don't have.opcode inFrameInfo in tests for instance). I'll check the remote debugging tests in regard to how they manage these structures.

SeeGH-143955.