Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
GH-143941: Move WASI-related files to Platforms/WASI#143942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Along the way, leave a deprecated Tools/wasm/wasi/__main__.py behind for backwards-compatibility.
zware left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM with a CODEOWNERS nit and a future archaeology suggestion. Note that I didn't really actually review any changes in__main__.py since it's completely recreated.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
StanFromIreland left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you please update:
| WASI_DIRS=frozenset({Path("Tools","wasm")}) |
Misc/NEWS.d/next/Build/2026-01-16-14-27-53.gh-issue-143941.TiaE-3.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This set of changes all makes sense to me.
The only concern I have is related to the integration with buildbots. As a result of this change, the buildbot will be invoking the deprecated entry point. That's fine for initial continuity of compatibility, but it strikes me as fragile in the long term.
However, AIUI, the buildbot doesn't have the ability to be configured for PR configurations on a per-branch basis (i.e., it's not possible to do a PR build with knowledge that it's a PR against a 3.X branch, and adjust rules accordingly). That means:
- it's not possible to fully deprecate the old endpoint until the oldest supported Python version has the new entry point
- it's not possible to use anynew feature of the entry point until such time as the old entry point has been deprecated.
The second point in particular is currently causing headaches for me with both Emscripten and iOS builds.
This doesn't have to block margin this PR; but this is a limitation that we'll need to address sooner rather than later, especially if we're planning to do this sort of migration for the Android, iOS, Apple and Tools/wasm/emscripten folders.
mhsmith commentedJan 19, 2026
It might be a little awkward, but couldn't we make the buildbot run a short script that checks for the existence of certain paths in the repository and adapts accordingly? |
zware commentedJan 19, 2026
We can do per-branch configuration on the buildbots, it's just not pretty :) |
brettcannon commentedJan 19, 2026
There's a reason I set the stated deprecation until 3.15 is EOL. 😅 I do have a note to clean it up once 3.20 comes out.
That was true before, though.
Something likehttps://github.com/python/buildmaster-config/blob/48d410a498ed40d2ff4b76cca9d6c822f72c31e9/master/custom/factories.py#L910 ?
You can do per-version if you set up distinct workers per version. |
webknjaz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The CI changes look fine. I only noticed one outdated reference to the old folder.
Misc/NEWS.d/next/Build/2026-01-16-14-27-53.gh-issue-143941.TiaE-3.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
freakboy3742 commentedJan 19, 2026
[@zware]
Oh! TIL - I've had a couple of conversations with people about this and everyone said it wasn't possible and needed fixes in buildbot itself... clearly I was asking the wrong people (or the wrong questions :-) ) |
mhsmith commentedJan 20, 2026
Even without any special support from the buildbot configuration system, we can always write commands asshell scripts like this:
|
emmatyping commentedJan 21, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Happy to answer questions on Discord if you have more. I spent quite a while reading through the buildbot docs and playing with things locally to figure this out for WASM things and learned a lot. I wouldn't however call myself an expert :) |
savannahostrowski left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yay, stoked about this!
brettcannon commentedJan 21, 2026
!buildbot wasi |
bedevere-bot commentedJan 21, 2026
🤖 New build scheduled with the buildbot fleet by@brettcannon for commit037c492 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143942%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
6181b69 intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Along the way, leave a deprecated
Tools/wasm/wasi/__main__.pybehind for backwards-compatibility.Platforms/WASI#143941