Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-143941: Move WASI-related files to Platforms/WASI#143942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brettcannon merged 11 commits intopython:mainfrombrettcannon:platforms-dir
Jan 21, 2026

Conversation

@brettcannon
Copy link
Member

@brettcannonbrettcannon commentedJan 16, 2026
edited by webknjaz
Loading

Along the way, leave a deprecatedTools/wasm/wasi/__main__.py behind for backwards-compatibility.

emmatyping reacted with hooray emoji
Along the way, leave a deprecated Tools/wasm/wasi/__main__.py behind for backwards-compatibility.
Copy link
Member

@zwarezware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM with a CODEOWNERS nit and a future archaeology suggestion. Note that I didn't really actually review any changes in__main__.py since it's completely recreated.

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
@brettcannonbrettcannon self-assigned thisJan 16, 2026
@AlexWaygoodAlexWaygood removed their request for reviewJanuary 16, 2026 23:45
Copy link
Member

@StanFromIrelandStanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you please update:

WASI_DIRS=frozenset({Path("Tools","wasm")})

brettcannon reacted with thumbs up emoji
Copy link
Contributor

@freakboy3742freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This set of changes all makes sense to me.

The only concern I have is related to the integration with buildbots. As a result of this change, the buildbot will be invoking the deprecated entry point. That's fine for initial continuity of compatibility, but it strikes me as fragile in the long term.

However, AIUI, the buildbot doesn't have the ability to be configured for PR configurations on a per-branch basis (i.e., it's not possible to do a PR build with knowledge that it's a PR against a 3.X branch, and adjust rules accordingly). That means:

  • it's not possible to fully deprecate the old endpoint until the oldest supported Python version has the new entry point
  • it's not possible to use anynew feature of the entry point until such time as the old entry point has been deprecated.

The second point in particular is currently causing headaches for me with both Emscripten and iOS builds.

This doesn't have to block margin this PR; but this is a limitation that we'll need to address sooner rather than later, especially if we're planning to do this sort of migration for the Android, iOS, Apple and Tools/wasm/emscripten folders.

@mhsmith
Copy link
Member

It might be a little awkward, but couldn't we make the buildbot run a short script that checks for the existence of certain paths in the repository and adapts accordingly?

@zware
Copy link
Member

We can do per-branch configuration on the buildbots, it's just not pretty :)

@brettcannon
Copy link
MemberAuthor

As a result of this change, the buildbot will be invoking the deprecated entry point. That's fine for initial continuity of compatibility, but it strikes me as fragile in the long term.

There's a reason I set the stated deprecation until 3.15 is EOL. 😅 I do have a note to clean it up once 3.20 comes out.

  • it's not possible to use anynew feature of the entry point until such time as the old entry point has been deprecated.

That was true before, though.

It might be a little awkward, but couldn't we make the buildbot run a short script that checks for the existence of certain paths in the repository and adapts accordingly?

Something likehttps://github.com/python/buildmaster-config/blob/48d410a498ed40d2ff4b76cca9d6c822f72c31e9/master/custom/factories.py#L910 ?

We can do per-branch configuration on the buildbots, it's just not pretty :)

You can do per-version if you set up distinct workers per version.

Copy link
Member

@webknjazwebknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The CI changes look fine. I only noticed one outdated reference to the old folder.

@freakboy3742
Copy link
Contributor

[@zware]

We can do per-branch configuration on the buildbots, it's just not pretty :)

[@brettcannon]

It might be a little awkward, but couldn't we make the buildbot run a short script that checks for the existence of certain paths in the repository and adapts accordingly?

Something likehttps://github.com/python/buildmaster-config/blob/48d410a498ed40d2ff4b76cca9d6c822f72c31e9/master/custom/factories.py#L910 ?

Oh! TIL - I've had a couple of conversations with people about this and everyone said it wasn't possible and needed fixes in buildbot itself... clearly I was asking the wrong people (or the wrong questions :-) )

@mhsmith
Copy link
Member

Even without any special support from the buildbot configuration system, we can always write commands asshell scripts like this:

if [ -e Platforms ]; then ...; else ...; fi

emmatyping reacted with thumbs up emoji

@emmatyping
Copy link
Member

emmatyping commentedJan 21, 2026
edited
Loading

[@freakboy3742]

Oh! TIL - I've had a couple of conversations with people about this and everyone said it wasn't possible and needed fixes in buildbot itself... clearly I was asking the wrong people (or the wrong questions :-) )

Happy to answer questions on Discord if you have more. I spent quite a while reading through the buildbot docs and playing with things locally to figure this out for WASM things and learned a lot. I wouldn't however call myself an expert :)

freakboy3742 reacted with thumbs up emojifreakboy3742 and brettcannon reacted with heart emoji

Copy link
Member

@savannahostrowskisavannahostrowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yay, stoked about this!

@brettcannon
Copy link
MemberAuthor

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@brettcannon for commit037c492 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F143942%2Fmerge

The command will test the builders whose names match following regular expression:wasi

The builders matched are:

  • wasm32-wasi PR

@brettcannonbrettcannon merged commit6181b69 intopython:mainJan 21, 2026
57 checks passed
@brettcannonbrettcannon deleted the platforms-dir branchJanuary 21, 2026 22:32
@github-project-automationgithub-project-automationbot moved this from🧐 @webknjaz's review queue 📋 to🌈 Done 🦄 in📅 Procrastinating in publicJan 21, 2026
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zwarezwarezware approved these changes

@freakboy3742freakboy3742freakboy3742 approved these changes

@webknjazwebknjazwebknjaz approved these changes

@hugovkhugovkhugovk approved these changes

@savannahostrowskisavannahostrowskisavannahostrowski approved these changes

@emmatypingemmatypingemmatyping approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland approved these changes

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@brettcannonbrettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@brettcannon@mhsmith@zware@freakboy3742@emmatyping@bedevere-bot@webknjaz@hugovk@savannahostrowski@StanFromIreland

[8]ページ先頭

©2009-2026 Movatter.jp