Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34k
gh-136728: Refactor build.yml CI config and multissltests.py#143940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Changes fromall commits
a104f8a3fcbe0d5d8ec9a991c6b27b5149966381274e0a8ca1a90e0c1fcb49fdd969fb1edce1c334312082f1154056020308be1f2b2f353c31325c594a826d9113833942434af3f0824181e676File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -248,78 +248,32 @@ jobs: | ||
| free-threading: ${{ matrix.free-threading }} | ||
| os: ${{ matrix.os }} | ||
| build-ubuntu-ssltests: | ||
| name: 'Ubuntu SSL tests' | ||
| runs-on:ubuntu-24.04 | ||
| timeout-minutes: 60 | ||
| needs: build-context | ||
| if: needs.build-context.outputs.run-ubuntu == 'true' | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| # Keep 1.1.1w in our list despite it being upstream EOL and otherwise | ||
| # unsupported as it most resembles other 1.1.1-work-a-like ssl APIs | ||
| # supported by important vendors such as AWS-LC. | ||
| - { ssl: openssl, ssl_ver: 1.1.1w } | ||
| - { ssl: openssl, ssl_ver: 3.0.18 } | ||
| - { ssl: openssl, ssl_ver: 3.3.5 } | ||
| - { ssl: openssl, ssl_ver: 3.4.3 } | ||
| - { ssl: openssl, ssl_ver: 3.5.4 } | ||
hugovk marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| - { ssl: openssl, ssl_ver: 3.6.0 } | ||
| - { ssl: awslc, ssl_ver: 1.55.0 } | ||
| # See Tools/ssl/make_ssl_data.py for notes on adding a new version | ||
| env: | ||
| SSL_VER: ${{ matrix.ssl_ver }} | ||
| MULTISSL_DIR: ${{ github.workspace }}/multissl | ||
| SSL_DIR: ${{ github.workspace }}/multissl/${{ matrix.ssl }}/${{ matrix.ssl_ver }} | ||
| LD_LIBRARY_PATH: ${{ github.workspace }}/multissl/${{ matrix.ssl }}/${{ matrix.ssl_ver }}/lib | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| @@ -333,39 +287,40 @@ jobs: | ||
| - name: Configure SSL lib env vars | ||
| run: | | ||
| echo "MULTISSL_DIR=${GITHUB_WORKSPACE}/multissl" >> "$GITHUB_ENV" | ||
| echo "SSL_DIR=${GITHUB_WORKSPACE}/multissl/${{ matrix.ssl }}/${SSL_VER}" >> "$GITHUB_ENV" | ||
| echo "LD_LIBRARY_PATH=${GITHUB_WORKSPACE}/multissl/${{ matrix.ssl }}/${SSL_VER}/lib" >> "$GITHUB_ENV" | ||
| - name: 'RestoreSSL build' | ||
| id: cache-ssl | ||
| uses: actions/cache@v5 | ||
| with: | ||
| path: ./multissl/${{ env.SSL }}/${{env.SSL_VER }} | ||
| key: ${{env.IMAGE_OS_VERSION }}-multissl-${{ env.SSL }}-${{env.SSL_VER }} | ||
| - name: InstallSSL | ||
| if: steps.cache-ssl.outputs.cache-hit != 'true' | ||
| run: | | ||
| python3 Tools/ssl/multissltests.py \ | ||
| --steps=library \ | ||
| --base-directory "$MULTISSL_DIR" \ | ||
| --ssl ${{ matrix.ssl }} \ | ||
| --ssl-versions ${{ matrix.ssl_ver }} \ | ||
| --system Linux | ||
| - name: Add ccache to PATH | ||
| run: | | ||
| echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV" | ||
| - name: Configure CPython | ||
| run: | | ||
hugovk marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| CMD=(./configure CFLAGS="-fdiagnostics-format=json" --config-cache --enable-slower-safety --with-pydebug --with-openssl="$SSL_DIR") | ||
| if [ "${{ matrix.ssl }}" = "openssl" ]; then | ||
| "${CMD[@]}" | ||
| else | ||
| "${CMD[@]}" --with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl | ||
| fi | ||
hugovk marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| - name: Build CPython | ||
| run: make -j4 | ||
| - name: Display build info | ||
| run: make pythoninfo | ||
| - name: Verify python is linked to AWS-LC | ||
| if: matrix.ssl == 'aws-lc' | ||
| run: ./python -c 'import ssl; print(ssl.OPENSSL_VERSION)' | grep AWS-LC | ||
| - name: SSL tests | ||
| run: ./python Lib/test/ssltests.py | ||
| @@ -451,7 +406,7 @@ jobs: | ||
| key: ${{ runner.os }}-multissl-openssl-${{ env.OPENSSL_VER }} | ||
| - name: Install OpenSSL | ||
| if: steps.cache-openssl.outputs.cache-hit != 'true' | ||
| run: python3 Tools/ssl/multissltests.py --steps=library --base-directory "$MULTISSL_DIR" --ssl 'openssl' --ssl-versions "$OPENSSL_VER" --system Linux | ||
| - name: Add ccache to PATH | ||
| run: | | ||
| echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV" | ||
| @@ -569,7 +524,7 @@ jobs: | ||
| key: ${{ matrix.os }}-multissl-openssl-${{ env.OPENSSL_VER }} | ||
| - name: Install OpenSSL | ||
| if: steps.cache-openssl.outputs.cache-hit != 'true' | ||
| run: python3 Tools/ssl/multissltests.py --steps=library --base-directory "$MULTISSL_DIR" --ssl 'openssl' --ssl-versions "$OPENSSL_VER" --system Linux | ||
| - name: Add ccache to PATH | ||
| run: | | ||
| echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV" | ||
| @@ -695,8 +650,7 @@ jobs: | ||
| - build-windows-msi | ||
| - build-macos | ||
| - build-ubuntu | ||
| - build-ubuntu-ssltests | ||
| - build-ios | ||
| - build-wasi | ||
| - test-hypothesis | ||
| @@ -713,8 +667,7 @@ jobs: | ||
| allowed-failures: >- | ||
| build-android, | ||
| build-windows-msi, | ||
| build-ubuntu-ssltests, | ||
| test-hypothesis, | ||
| cifuzz, | ||
| allowed-skips: >- | ||
| @@ -745,8 +698,7 @@ jobs: | ||
| !fromJSON(needs.build-context.outputs.run-ubuntu) | ||
| && ' | ||
| build-ubuntu, | ||
| build-ubuntu-ssltests, | ||
| test-hypothesis, | ||
| build-asan, | ||
| build-san, | ||
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.