NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-136728: Refactor build.yml CI config and multissltests.py#143940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

hugovk wants to merge22 commits intopython:main

base:main

Choose a base branch

fromhugovk:3.15-refactor-ssl-tests

Draft

gh-136728: Refactor build.yml CI config and multissltests.py#143940

hugovk wants to merge22 commits intopython:mainfromhugovk:3.15-refactor-ssl-tests

Conversation

Copy link

Member

hugovk commentedJan 16, 2026•
edited by bedevere-appbot
Loading

Continuation of#136729.

Original description:

Notes

Please see#136728. Changes tobuild.yml are directly adapted from@hugovk's proof-of-concepthere.

Testing

this PR's CI
PR CI on my fork.

Issue:Refactor build.yml CI ssltests config and multissltests.py #136728

WillChilds-Kleinand others added16 commits

July 14, 2025 21:19

Adapt@hugovk's proof-of-concept CI definition refactor

a104f8a

Suggested by@hugovk [1].[1]:a3f2ba9

Preliminary refactor of multissltests.py, TODO migrate to classes

3fcbe0d

Fix aws-lc/awslc lib name discrepancy

5d8ec9a

Migrate AbstractBuilder to abc

991c6b2

Fix imports

7b51499

Complete ABC refactor

6638127

Colorize parser

4e0a8ca

Adjust compatibility comment

1a90e0c

📜🤖 Added by blurb_it.

1fcb49f

Revert "📜🤖 Added by blurb_it."

dd969fb

This reverts commit1fcb49f.

Merge branch 'main' into refactor-ssl-tests

1edce1c

Include old versions when using default versions

3343120

Merge remote-tracking branch 'upstream/main' into 3.15-refactor-ssl-t…

82f1154

…ests

Apply suggestions from code review

0560203

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>

Bump GitHub Actions

08be1f2

Merge remote-tracking branch 'upstream/main' into 3.15-refactor-ssl-t…

b2f353c

…ests

bedevere-appbot mentioned this pull request

Jan 16, 2026

Refactor build.yml CI ssltests config and multissltests.py#136728

Open

hugovk mentioned this pull request

Jan 16, 2026

gh-136728: Refactor build.yml CI config and multissltests.py#136729

Closed

hugovk added skip news infraCI, GitHub Actions, buildbots, Dependabot, etc. labels

Jan 16, 2026

hugovk added3 commits

January 16, 2026 23:58

Retain multiline

31325c5

Use extend instead of += [...]

94a826d

Remove 3.3 block, use long options

9113833

webknjaz reviewed

Jan 16, 2026

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

webknjaz reviewed

Jan 16, 2026

View reviewed changes

.github/workflows/build.yml

		run: \|
		echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV"
		- name: Configure CPython
		run: \|

Copy link

Member

webknjazJan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

>- makes EOL escaping redundant while allowing for nice line separation of long/logically self-contained components:

Suggested change

	run:\|
	env:
	CONFIGURE_TRAILING_ARGS:>-
	${{
	matrix.ssl != 'openssl'
	&& '--with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl'
	\|\| ''
	}}
	run:>-

Copy link

Member

picnixzJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer \ becauseI find them easier to read. I find the >- harder to read honestly.

webknjaz reviewed

Jan 16, 2026

View reviewed changes

.github/workflows/build.yml

Comment on lines +312 to +317

		CMD=(./configure CFLAGS="-fdiagnostics-format=json" --config-cache --enable-slower-safety --with-pydebug --with-openssl="$SSL_DIR")
		if [ "${{ matrix.ssl }}" = "openssl" ]; then
		"${CMD[@]}"
		else
		"${CMD[@]}" --with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl
		fi

Copy link

Member

webknjazJan 16, 2026•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	CMD=(./configure CFLAGS="-fdiagnostics-format=json" --config-cache --enable-slower-safety --with-pydebug --with-openssl="$SSL_DIR")
	if [ "${{ matrix.ssl }}" = "openssl" ]; then
	"${CMD[@]}"
	else
	"${CMD[@]}"--with-builtin-hashlib-hashes=blake2 --with-ssl-default-suites=openssl
	fi
	./configure
	CFLAGS="-fdiagnostics-format=json"
	--config-cache
	--enable-slower-safety
	--with-pydebug
	--with-openssl="$SSL_DIR"
	${CONFIGURE_TRAILING_ARGS}

Copy link

Member

picnixzJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I prefer the if/else approach. I do not like the notion of 'trailing' args.

webknjaz added this to📅 Procrastinating in public

Jan 16, 2026

webknjaz moved this to🧐 @webknjaz's review queue 📋 in📅 Procrastinating in public

Jan 16, 2026

picnixz reviewed

Jan 17, 2026

View reviewed changes

Tools/ssl/multissltests.py


		@property
		@abstractmethod
		def library(self=None):

Copy link

Member

picnixzJan 17, 2026•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So as I said previously, we should just have annotated properties. It will complain at runtime if we are missing one.

Copy link

MemberAuthor

hugovkJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please could you make GH suggestions here, or a PR to my branch?

Copy link

Member

picnixzJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am sorry I am on mobile only (I am travelling) so I cannot do it easily :(

Copy link

MemberAuthor

hugovkJan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No rush, it can wait!

Tools/ssl/multissltests.py OutdatedShow resolvedHide resolved

Apply suggestions from code review

942434a

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

hugovk commented

Jan 20, 2026

View reviewed changes

.github/workflows/build.yml OutdatedShow resolvedHide resolved

.github/workflows/build.ymlShow resolvedHide resolved

Tools/ssl/multissltests.py OutdatedShow resolvedHide resolved

Tools/ssl/multissltests.pyShow resolvedHide resolved

hugovk added2 commits

January 20, 2026 17:29

Add support for OpenSSL 3.6, drop EOL 3.2

f3f0824

Followingpython#143961

Merge branch 'main' into 3.15-refactor-ssl-tests

181e676

Labels

infra

CI, GitHub Actions, buildbots, Dependabot, etc.

skip news

Movatterモバイル変換

Uh oh!

gh-136728: Refactor build.yml CI config and multissltests.py#143940

Are you sure you want to change the base?

gh-136728: Refactor build.yml CI config and multissltests.py#143940

Uh oh!

Conversation

hugovk commentedJan 16, 2026• edited by bedevere-appbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Notes

Testing

Uh oh!

Uh oh!

webknjazJan 16, 2026

Choose a reason for hiding this comment

Uh oh!

picnixzJan 17, 2026

Choose a reason for hiding this comment

Uh oh!

webknjazJan 16, 2026• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

picnixzJan 17, 2026

Choose a reason for hiding this comment

Uh oh!

picnixzJan 17, 2026• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugovkJan 17, 2026

Choose a reason for hiding this comment

Uh oh!

picnixzJan 17, 2026

Choose a reason for hiding this comment

Uh oh!

hugovkJan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hugovk commentedJan 16, 2026•
edited by bedevere-appbot
Loading

webknjazJan 16, 2026•
edited
Loading

picnixzJan 17, 2026•
edited
Loading