Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-143923: Reject control characters in POP3 commands#143924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@sethmlarson
Copy link
Contributor

@sethmlarsonsethmlarson commentedJan 16, 2026
edited by bedevere-appbot
Loading

@sethmlarsonsethmlarson requested a review froma team as acode ownerJanuary 16, 2026 17:48
@sethmlarsonsethmlarson added type-securityA security issue needs backport to 3.10only security fixes needs backport to 3.11only security fixes needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 16, 2026
@bitdancer
Copy link
Member

Here I have a backward compatibility concern. While the RFC makes it clear that non-printables other than space are not acceptable in commands, I can imagine people using passwords with things like tab and backspace in them, and while that would violate the RFC, it would currentlywork, and this would break that.

What do you think?

Note that since this is the client side, this is not, IMO, a security issue, it's more of an RFC conformance issue.

@Yhg1s
Copy link
Member

Yeah, I agree. This is fine on main but I'm not sure I'd backport it, even as a bugfix.

sethmlarson reacted with thumbs up emoji

@sethmlarsonsethmlarson removed needs backport to 3.10only security fixes needs backport to 3.11only security fixes needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsJan 20, 2026
@sethmlarson
Copy link
ContributorAuthor

For now we'll hold off on backporting this PR as they are potentially breaking some existing behavior.

@sethmlarsonsethmlarson merged commitb234a2b intopython:mainJan 20, 2026
71 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadAwaiting requested review from gpshead

Assignees

No one assigned

Labels

type-securityA security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethmlarson@bitdancer@Yhg1s

[8]ページ先頭

©2009-2026 Movatter.jp