NotificationsYou must be signed in to change notification settings
Fork34k
Star71.3k

gh-143904: Raise OverflowError instead of IndexError for too large offset in struct.pack_into()#143905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:struct-pack_into-offset-overflow-error

Feb 1, 2026

Merged

gh-143904: Raise OverflowError instead of IndexError for too large offset in struct.pack_into()#143905

serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:struct-pack_into-offset-overflow-error

Feb 1, 2026

+42 −25

Conversation

Copy link

Member

serhiy-storchaka commentedJan 16, 2026•
edited by bedevere-appbot
Loading

Issue:Replace IndexError with OverflowError in struct.pack_into() #143904

pythongh-143904: Raise OverflowError instead of IndexError for too la…

bb93522

…rge offset in struct.pack_into()

serhiy-storchaka requested a review fromskirpichev

January 16, 2026 12:05

bedevere-appbot mentioned this pull request

Jan 16, 2026

Replace IndexError with OverflowError in struct.pack_into()#143904

Closed

bedevere-appbot added the awaiting core review label

Jan 16, 2026

skirpichev reviewed

Jan 16, 2026

View reviewed changes

Modules/_struct.c


		buffer: Py_buffer(accept={rwbuffer})
		offset as offset_obj: object
		offset: Py_ssize_t

Copy link

Member

skirpichevJan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This long-time behavior, I think we need a deprecation.

Copy link

MemberAuthor

serhiy-storchakaJan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This behavior is uncommon, it was not documented and not covered by tests, it should not occur in normal code. This looks like a long-time bug, we just do not backport its fix.

It is not easy to deprecate a raised exception, and deprecation will have effect comparable with simple changing the exception type. We usually do not do this.